[No QA] Docs updates for E/A#97811 Add Vendor action field to Merchant Rules - #98481
Draft
MelvinBot wants to merge 1 commit into
Draft
[No QA] Docs updates for E/A#97811 Add Vendor action field to Merchant Rules#98481MelvinBot wants to merge 1 commit into
MelvinBot wants to merge 1 commit into
Conversation
Co-authored-by: Alex Beaman <Beamanator@users.noreply.github.com>
48 tasks
Contributor
Author
|
There's nothing to fix here — no code check is failing. The only red check is Check independent approval, which isn't a build/test failure. It fails simply because the PR hasn't received an independent approval yet; it clears automatically once a reviewer other than the author approves. Every actual CI check is green: So no push is needed. To turn this check green, this PR just needs an independent review/approval. |
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://abb6d049.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documents the new Vendor action field on Merchant Rules, added to NewDot in #97811 (vendor matching R5, Phase B).
That PR lets Workspace Admins set a specific vendor on every expense a Merchant Rule matches, so non-reimbursable company card expenses export with the correct vendor. The field is labeled Supplier on Xero workspaces and is available only on workspaces connected to QuickBooks Online, Sage Intacct, or Xero. The existing QuickBooks Online vendor matching article already references "if a workspace merchant rule specifies a vendor," but the Merchant Rules article did not yet document this field — this PR closes that gap.
Changes to
Workspace-Merchant-Rules.mdNotes for the reviewer
vendorMatchingbeta in addition to the connected-integration requirement. The docs do not mention the beta (matching the precedent of the already-published QBO vendor matching article). If the feature is not yet generally available, please hold this PR until GA.src/languages/en.tsand the PR's UI code (common.vendor,common.supplier), since the beta gate prevents surfacing the field in the standard test session.@Beamanator, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.