Add Canadian Multiple Tax Export template to New Expensify for workspaces using CAD - #97853
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5dc7ec2e8f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
trjExpensify
left a comment
There was a problem hiding this comment.
Someone asked for this again today! 👍
|
@thelullabyy kindly bump |
Reviewer Checklist
Screenshots/VideosiOS: HybridAppScreen.Recording.2026-08-02.at.18.03.34.movMacOS: Chrome / SafariScreen.Recording.2026-08-02.at.17.43.32.mov |
|
I think we should update the test steps, currently I still can see the
|
|
@thelullabyy I think canadian tax filing is workspace-level. A CAD workspace files in CAD; a foreign-currency expense still belongs on that report, converted. Excluding it would produce an incomplete tax export, which is worse than including it. |
|
Alright, then... it looks good now |
NikkiWines
left a comment
There was a problem hiding this comment.
I think we should also add template this to getFilterDisplayValue in SearchQueryUtils.cpp. Weird that we haven't added other there though 🤔
|
@NikkiWines Done |
|
Merged main again. @NikkiWines can you check it again 🙏 ? |
trjExpensify
left a comment
There was a problem hiding this comment.
re-approving from product 👍
|
🚧 NikkiWines has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.4.53-0 🚀
|
|
🤖 Help site review complete — changes are required. This PR adds a new default export template, Canadian Multiple Tax Export, that appears in the export template menu for both expenses and reports whenever a workspace's output currency is set to CAD. The two New Expensify help articles that list the available export templates don't mention it, so they need updating. Draft help site PR: #98478 What it updates:
The template name is used verbatim from the app's language strings ( @dukenv0307, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #98536 was identified to be related to this PR. |
|
Deploy Blocker #98541 was identified to be related to this PR. |


Explanation of Change
Adds the Canadian Multiple Tax Export template to New Expensify for workspaces whose output currency is CAD, and includes the fixes for the three regressions the original PR caused before it was reverted
Fixed Issues
$ #97231
PROPOSAL:
Tests
Precondition:
Test case 1:
Test case 2:
→ Verify that Canadian Multiple Tax Export icon shows the default export icon.
→ Verify that Canadian Multiple Tax Export icon shows the default export icon.
Test case 3:
Offline tests
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-08-05.at.2.23.21.PM.mov