Remove broken-card task and RBR after a 90-day grace period while keeping the error

[wildan-m]

Explanation of Change

A personal or company card whose connection has broken keeps prompting the user indefinitely: the time-sensitive home task and the red dot (RBR) pointing at the broken connection stay forever, no matter how long the connection has gone unresolved. Both surfaces are driven by a single derived signal that only looks at the latest connection status — there is no notion of how long the connection has been failing, so a years-old broken connection nags exactly as much as one that broke yesterday.

This adds a 90-day grace period to that single signal: once a connection has been broken and unresolved for 90 days, it stops feeding the task and the red dots. The age is measured from the connection's last successful refresh, which does not advance while the connection is failing, so it accurately reflects how long the connection has been broken (and if that timestamp is missing we keep prompting, to stay on the safe side). The error stored on the card is deliberately left alone, so the card still shows as broken on its own page and stays fixable — under 90 days nothing changes, and past 90 days only the proactive prompting goes away.

Fixed Issues

$ #91451
PROPOSAL: #91451 (comment)

Tests

1. Sign in to an account that has a card with a broken feed connection (a lastScrapeResult that is not one of the recoverable/ignored statuses). Confirm the broken connection currently surfaces: the "Fix the connection" task appears in the Inbox time-sensitive section, and a red dot (RBR) appears — for a personal card on the Account button and the Wallet row; for a company card on the workspace's company-cards surfaces.
2. Ensure the connection's last successful refresh ("Last updated") is less than 90 days ago. Verify the time-sensitive task and the red dot are still shown (behavior unchanged for recently-broken connections).
3. Make that same broken connection's last successful refresh 90 or more days old.
4. Verify the time-sensitive task is removed and the red dot (RBR) is gone — on the Account/Wallet rows for a personal card, and on the company-cards surfaces for a company card.
5. Open the card's own detail page and verify the broken-connection error is still shown there and the reconnect/fix action is still available — i.e. the connection remains fixable; only the proactive prompting was removed.
6. Edge case: with the broken connection but no last-successful-refresh timestamp recorded, verify the task and red dot are still shown (fail-safe — we keep prompting).
7. Verify that no errors appear in the JS console.

Local web verification (MacOS Chrome, dev server): with a broken personal card whose last refresh was 7 days ago, the Wallet row under Account shows the red dot; after changing only the last-refresh age to 100 days ago (the connection still broken), the red dot disappears while the card's broken status is preserved. Confirmed end-to-end through the live derived card-feed-errors value for both the personal path and the company/workspace path.

Offline tests

This change only gates a value derived from already-local card data and the device date — no network is involved. It behaves identically offline: a connection broken past the 90-day window stays unprompted, and one within the window keeps prompting, whether online or offline.

QA Steps

Same as Tests. Note: reproducing requires a card whose connection has been broken (non-recoverable lastScrapeResult) with a last-successful-refresh timestamp older than 90 days; cards broken for less than 90 days must still show the task and RBR.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Verified locally on the dev server: a broken personal card's RBR red dot on the Account > Wallet row is shown when the connection broke under 90 days ago, and is removed once the connection has been broken for 90+ days, while the card's broken status is preserved.