Open
Conversation
- Bump Java source/target/release to 21 across all modules - Upgrade Spring Boot from 2.7.9 to 3.2.12 - Migrate javax.* to jakarta.* (persistence, servlet, annotation) - Add CrudRepository to repository interfaces (Spring Data 3.x breaking change) - Update springdoc-openapi from 1.x to 2.x (GroupedOpenApi, ParameterObject) - Fix Testcontainers LocalStack API: getEndpointOverride() replaces getEndpointConfiguration() - Fix Awaitility 4.x: replace org.awaitility.Duration with java.time.Duration - Fix Hadoop+Java21: disable FileSystem cache to avoid UserGroupInformation incompatibility - Add JVM --add-opens flags for Hadoop/reflection compatibility in tests - Exclude JPA auto-configuration from @WebMvcTest context in API tests Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Replace JUnit 4 @rule with @container on LocalStack S3 containers in BeekeeperMetadataCleanupIntegrationTest and BeekeeperDryRunMetadataCleanupIntegrationTest to fix ExceptionInInitializerError caused by static block running before Testcontainers start - Add properties.sqs.endpoint and properties.sqs.region Spring properties to CommonBeans.messageReader() so the SqsMessageReader uses a custom AmazonSQS client with explicit LocalStack endpoint and matching region (us-west-2), fixing QueueDoesNotExistException caused by LocalStack's region-sensitive SQS queue lookup - Set properties.sqs.region in BeekeeperUnreferencedPathSchedulerApiaryIntegrationTest and BeekeeperExpiredMetadataSchedulerApiaryIntegrationTest to match the region used when creating SQS queues in LocalStack - Apply Spotless formatting to all changed integration test files All 71 integration tests now pass (1 skipped, pre-existing). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- PagingMetadataCleanupServiceTest: fix ArgumentCaptor type from HousekeepingPath to HousekeepingEntity to match the actual type passed to PathCleaner.cleanupPath(HousekeepingEntity) - CommonBeans (path-cleanup): remove spurious withPathStyleAccessEnabled(true) from amazonS3Test() which caused URL host to be "endpoint" instead of "bucket.endpoint" as the test expected Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
After Java 21 / Spring Boot 3.2.12 upgrade, LocalDateTime.now() produces nanosecond-precision timestamps but H2 (MySQL mode) stores DATETIME with microsecond precision, causing round-trip comparison failures and incorrect query boundary evaluations. Truncate CREATION_TIMESTAMP and compare() helper to MICROS to align in-memory values with DB-stored values. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
… test Same nanosecond vs microsecond precision issue as in beekeeper-core tests. H2 (MySQL mode) truncates DATETIME to microseconds, causing the cleanupTimestamp round-trip comparison to fail after Java 21 upgrade. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
SpotBugs 4.0.4 (inherited from eg-oss-parent) uses an outdated ASM library that cannot parse Java 21 class files (major version 65), causing the CI build to fail with NoClassesFoundToAnalyzeException. Overriding maven.spotbugs.plugin.version to 4.8.6.6 resolves the issue. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jamespfaulkner
left a comment
jamespfaulkner
left a comment
There was a problem hiding this comment.
Is there something preventing us from going to the latest spring boot 3.5.x?
Comment on lines
+190
to
+192
| <source>21</source> | ||
| <target>21</target> | ||
| <release>21</release> |
There was a problem hiding this comment.
Can probably just use the jdk.version property here
Comment on lines
+241
to
+243
| <source>21</source> | ||
| <target>21</target> | ||
| <release>21</release> |
| with: | ||
| distribution: 'adopt' | ||
| java-version: '11' | ||
| distribution: 'corretto' |
There was a problem hiding this comment.
Minor question. Is there a reason we use corretto here but temurin as the base image?
Collaborator
Author
There was a problem hiding this comment.
AdoptOpenJDK (adopt) no longer distributes Java 21. AdoptOpenJDK stopped releasing new JDK versions after JDK 17.
| <jackson.version>2.17.2</jackson.version> | ||
| <snakeyaml.version>2.2</snakeyaml.version> | ||
| <springframework.boot.version>3.2.12</springframework.boot.version> | ||
| <springframework.version>6.1.15</springframework.version> |
There was a problem hiding this comment.
Is this used now we've removed the direct springframework dependencies from the pom?
Collaborator
Author
There was a problem hiding this comment.
Will remove that line as it is not needed anymore
Remove hardcoded '21' from maven.compiler.source/target/release, docker.from.tag,
and both maven-compiler-plugin configurations, replacing them with ${jdk.version}.
Also remove unused springframework.version property now that direct Spring
dependencies are managed by the spring-boot-dependencies BOM.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ninhomilton
force-pushed
the
UpgradeJava21
branch
from
fffe1b0 to
5eaeed4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade to Java 21 and Spring Boot 3.2.12
build.yml,main.yml,release.yml) to usejava-version: 21LocalDateTimeto microseconds in repository tests to match MySQL precisionMySQLDialect, JPA config updates)spotbugs-maven-pluginto 4.8.6.6 and other dependencies for Java 21 compatibility