Skip to content

refactor: convert package to typescript#40

Closed
guten-exodus wants to merge 1 commit into
masterfrom
guten/convert-fetch-to-typescript
Closed

refactor: convert package to typescript#40
guten-exodus wants to merge 1 commit into
masterfrom
guten/convert-fetch-to-typescript

Conversation

@guten-exodus
Copy link
Copy Markdown

@guten-exodus guten-exodus commented Apr 29, 2026

Summary

  • Provide types support
  • Convert package source and tape tests from JavaScript to TypeScript under src/ and test/.
  • Add tsc build/typecheck configs that emit CommonJS JS and .d.ts files to lib/.
  • Point package exports/files at built lib artifacts and align CI/release Node with Hydra's Node 24.14.0 runtime.

Test plan

  • npm run typecheck
  • npm run lint
  • npm test
  • npm pack --dry-run

Made with Cursor

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ChALkeR
Copy link
Copy Markdown
Contributor

ChALkeR commented Apr 29, 2026

Not needed until a v2 rewrite.
Most of this package will be dropped soon.

@guten-exodus
Copy link
Copy Markdown
Author

I used it here

@ChALkeR
Copy link
Copy Markdown
Contributor

ChALkeR commented Apr 29, 2026

#25 should be finished and land this week
This PR will have to be remade after that

Also, there is no much value in converting this to ts, what you need is just .d.ts types.

Copy link
Copy Markdown
Contributor

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not until v2

@guten-exodus
Copy link
Copy Markdown
Author

SGTM, closed for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants