chore(deps): bump @exadev/eslint-config to 2.12.1 - #113
Merged
Conversation
Pulls in the JSDoc/TSDoc quality rule from 2.11.0, the Stryker-comment ban and 800-line file cap from 2.12.0, and 2.12.1's pinned eslint-plugin-jsdoc dependency, across every package that depends on it: core, node, cloudflare-hub, web-console, and conformance.
…fig from release-age gating Sets saveExact so a future pnpm add pins a precise version instead of a caret range, and excludes @exadev/eslint-config from minimumReleaseAge since ExaDev controls its release pipeline and the gate's threat model (a compromised third-party maintainer) doesn't apply to a package we publish ourselves. Written to pnpm-workspace.yaml, the location pnpm 11+ actually reads, with a matching .npmrc fallback for pnpm 10.x releases older than 10.17.
bytesFromRawData's doc comment used bare "->" arrows to describe the decode -> store -> re-encode round trip; TSDoc parses an unescaped ">" as a possible HTML tag close, so escape each one to keep the comment valid syntax.
…-line cap tokens.test.ts had grown to 1669 lines, past eslint-config's new max-lines rule. Extracts the shared signing/identity/encoding helpers into tokens-fixtures.ts and divides the describe blocks by concern: core verifyCapabilityToken checks (signature, expiry, revocation, bearer, and hostile-input handling), delegation-chain narrowing rules, verifyRevocationEntry plus the memory-storage/system-clock adapters, and mintCapabilityToken/canGrant/mintRevocationEntry. All 60 original test cases carry over unchanged.
…he 800-line cap mesh-session.test.ts had grown to 1761 lines, past eslint-config's new max-lines rule. Extracts the shared FakeConnection fixture, transport factories, and timing helpers into mesh-session-fixtures.ts, and divides the describe blocks by concern: createMeshSession, reconnect policy, capability-token/manage-request plumbing, revocation-announce plumbing, relay routing, and acceptMeshSession. All 75 original test cases carry over unchanged.
Updates the packageManager field in every package.json that carries one (the ts/ and conformance/ workspace roots, plus the four standalone-installable ts/packages/* leaves) from pnpm 10.33.0 to 12.4.1 via corepack, regenerating both lockfiles for the new engine. pnpm 12 stopped reading a package.json "pnpm.overrides" block, so ts/'s conventional-changelog-writer override moves to pnpm-workspace.yaml's own overrides field. pnpm 12 also hard-fails an install with unapproved build scripts rather than warning; explicitly disallows esbuild, sharp, and workerd in both workspaces' allowBuilds, matching their existing behaviour under pnpm 10, where these same scripts were already silently ignored without being run.
Mearman
marked this pull request as ready for review
September 14, 2026 08:52
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
@exadev/eslint-configfrom 2.10.6 to 2.12.1 across every package that depends on it (core, node, cloudflare-hub, web-console, conformance).Since 2.10.6, the config gained a JSDoc/TSDoc quality rule (2.11.0), a ban on Stryker-suppression comments plus an 800-line file cap (2.12.0), and a pinned
eslint-plugin-jsdocdependency (2.12.1, no rule changes).Fallout from the new rules, fixed at the root cause rather than suppressed:
tsdoc-escape-greater-than: one doc comment inwire-mesh-nodeused bare->arrow notation, which TSDoc parses as a possible HTML tag; escaped the>characters.tsdoc-html-tag-missing-greater-than/tsdoc-escape-greater-than: a test comment referencedOmit<TokenClaims, ...>as plain prose; wrapped it in backticks as an inline code span.max-lines:core/test/tokens.test.ts(1669 lines) andcore/test/mesh-session.test.ts(1761 lines) both exceeded the new 800-line cap. Split each into a shared fixtures module plus several per-concern test files (grouped by which exported function/behaviour each describe block covers), rather than chopping by line count. All 60 and 75 original test cases respectively carry over unchanged, confirmed by test-count parity and a full green run.No Stryker-suppression comments existed in this repo, so
no-warning-commentsneeded no fixes.Also sets
saveExact: trueand excludes@exadev/eslint-configfromminimumReleaseAge(ExaDev controls that package's own release pipeline), written to bothpnpm-workspace.yaml(the location pnpm 11+ reads) and.npmrc(the pnpm-10.x-pre-10.17 fallback), for both thets/workspace and the standaloneconformance/package.