Implement built-in SQL create, update and delete - #2
Conversation
tonydamage
left a comment
tonydamage
left a comment
There was a problem hiding this comment.
Please rebase / merge latest masters and integrate your changes into newly introduced Operation Builder hierarchy. See also comments.
| return this; | ||
| } | ||
|
|
||
| /** Registers a built-in handler without replacing an explicitly configured one. */ |
There was a problem hiding this comment.
After rebase on latest changes, the operations should be build using sepearate (per operation) SqlObject*BuilderImpl via SqlObjectOperationBuilderImpl
Registration is handled automatically the builder
| } else { | ||
| var templatesBuilder = new SQLTemplatesRegistry().getBuilder(meta); | ||
| templatesFromRegistry = templatesBuilder != null | ||
| ? templatesBuilder.printSchema().quote().build() |
There was a problem hiding this comment.
curious, why is this needed?
| return null; | ||
| } | ||
|
|
||
| protected Map<Path<?>, Object> createAssignments( |
There was a problem hiding this comment.
Let's use different name then assignments (may be confusing for midPoint developers / operators) ... my understanding is tht this is column / value pairing right?
| handlerBuilder.register(oc, ObjectSearchOperation.class, new SqlSearchOperation(context, def)); | ||
| handlerBuilder.register(oc, ObjectSyncOperation.class, | ||
| new SqlSyncOperation(context, def, SyncConfig.defaultFor(def))); | ||
| handlerBuilder.registerIfAbsent( |
There was a problem hiding this comment.
This should not be necessary after rebase
2 participants
Summary
Implements connector story #11421.
Testing