-
Notifications
You must be signed in to change notification settings - Fork 5.2k
fix: melhora a formatação e tratamento de erros na função getExistingSourceIds #1494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -177,24 +177,25 @@ class ChatwootImport { | |
| return existingSourceIdsSet; | ||
| } | ||
|
|
||
| const formattedSourceIds = sourceIds.map((sourceId) => `WAID:${sourceId.replace('WAID:', '')}`); // Make sure the sourceId is always formatted as WAID:1234567890 | ||
| let query: string; | ||
| if (conversationId) { | ||
| query = 'SELECT source_id FROM messages WHERE source_id = ANY($1) AND conversation_id = $2'; | ||
| } else { | ||
| query = 'SELECT source_id FROM messages WHERE source_id = ANY($1)'; | ||
| } | ||
|
|
||
| // Ensure all sourceIds are consistently prefixed with 'WAID:' as required by downstream systems and database queries. | ||
| const formattedSourceIds = sourceIds.map((sourceId) => `WAID:${sourceId.replace('WAID:', '')}`); | ||
| const pgClient = postgresClient.getChatwootConnection(); | ||
| const result = await pgClient.query(query, [formattedSourceIds, conversationId]); | ||
|
|
||
| const params = conversationId ? [formattedSourceIds, conversationId] : [formattedSourceIds]; | ||
|
|
||
| const query = conversationId | ||
| ? 'SELECT source_id FROM messages WHERE source_id = ANY($1) AND conversation_id = $2' | ||
| : 'SELECT source_id FROM messages WHERE source_id = ANY($1)'; | ||
|
|
||
| const result = await pgClient.query(query, params); | ||
| for (const row of result.rows) { | ||
| existingSourceIdsSet.add(row.source_id); | ||
| } | ||
|
|
||
| return existingSourceIdsSet; | ||
| } catch (error) { | ||
| return null; | ||
| this.logger.error(`Error on getExistingSourceIds: ${error.toString()}`); | ||
| return new Set<string>(); | ||
| } | ||
| } | ||
|
|
||
|
|
@@ -336,7 +337,6 @@ class ChatwootImport { | |
|
|
||
| this.deleteHistoryMessages(instance); | ||
| this.deleteRepositoryMessagesCache(instance); | ||
| return 0; | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @oriondesign2015 Não tem porque ter |
||
| } | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.