Fix: Expiration being useless on awaitUser false #1264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que foi feito
Removi uma validação de await user na função do controller do typebot e coloquei ela posteriomente dentro do service (processTypebot)
Por que isso é necessário
Atualmente caso caia em uma situação onde a sessão está expirada, mas o awaitUser está false, não entra na função que efetua corretamente a reabertura da sessão expirada, ficando a sessão aberta até que seja manualmente deletada.
Observação
Tive esse problema acontendo ocasionalmente, e após procurar, encontrei uma issue citando esse mesmo problema #1260