Skip to content

Conversation

@erixcel
Copy link

@erixcel erixcel commented Feb 7, 2025

This pull request includes significant updates to the environment configuration files, Docker setup, and the .dockerignore file. The changes aim to improve the configuration management and containerization of the application. Below are the most important changes:

Environment Configuration Updates:

  • .env.example.local: Renamed from .env.example and updated with new environment variables, including PRISMA_MIGRATIONS, DATABASE_CONNECTION_URI, and DATABASE_CONNECTION_URL. Removed several unused variables.
  • .env.example.railway: Added a new example configuration file for Railway with comprehensive environment variables for database, RabbitMQ, Pusher, and other services.
  • .env.example.supabase: Added a new example configuration file for Supabase with detailed environment settings similar to the Railway configuration.

Docker and Docker Compose Changes:

  • Dockerfile: Refactored to use a multi-stage build process with a more descriptive and organized structure. The new Dockerfile uses node:20 for building and node:20-slim for the production stage, improving efficiency and readability.
  • docker-compose.dev.yaml: Removed the development Docker Compose configuration file, which included services, volumes, and networks for the API.

Docker Ignore File:

  • .dockerignore: Updated to ignore additional files such as npm-debug.log and .env, while removing patterns for Docker-related files.

@dpaes
Copy link

dpaes commented Feb 7, 2025

i think ur PR its going to the wrong branch (all PR's have to go to develop), u need to put comments in english, and why include migration environment variable? all migrations need to be start in the beginning.
why remove the comments in the .env examples?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants