Skip to content
This repository was archived by the owner on Nov 10, 2026. It is now read-only.

Read "1 failed, 0 errors" as a failure and a question as no correction - #53

Merged
forrestlinfeng merged 1 commit into
mainfrom
fix/check-and-correction-reading
Oct 26, 2026
Merged

forrestlinfeng merged 1 commit into
mainfrom
fix/check-and-correction-reading

Conversation

@forrestlinfeng

Copy link
Copy Markdown
Contributor

Two misreadings, found while aligning the Codex and WorkBuddy plugins with this one (they already carry the fixed versions).

Check output

verificationFailed dropped every output line that held a zero count, so a mixed summary lost its failure along with the line:

verificationFailed({ content: [{ type: 'text', text: 'Tests: 1 failed, 0 errors' }] }) // false on main

It matters whenever the exit code is gone — the reason output is read at all is that dsh's bash reports a failing command piped through tail as a success. Only the zero counts are removed now (replace with a global pattern), so 0 failed / failures: 0 still read as a pass and 1 failed, 0 errors reads as a failure.

Corrections

looksLikeCorrection already spared 行不行 / 对不对, but took 不行吗?, 这样不对吧, 不对吧。 for a correction. A correction revises the reuse report (L3 failed) and drops the turn's distillation candidate, so a question cost a valid Gene. 不行 / 不对 no longer count when what follows asks for an opinion: 吗/嘛/么, a question mark, or a closing 吧. A plain 这样不对, 不行,还是报错 or 不对吧,你再看看 is still a correction.

Tests

New cases in test/verification.test.js and test/feedback-label.test.js (both fail on main). npm test: 185 pass.

🤖 Generated with Claude Code

Two misreadings, found while porting this logic to the Codex and WorkBuddy plugins:

- verificationFailed dropped every output line holding a zero count, so `Tests: 1 failed, 0 errors`
  lost its failure with the line and read as a pass whenever the exit code was gone (output piped through
  `tail`). Only the zero counts themselves are dropped now.
- looksLikeCorrection took `不行吗?`, `这样不对吧` or `不对吧。` for a correction, which revised a reuse
  report and dropped a valid distillation candidate. `不行` and `不对` no longer count when what follows
  asks for an opinion (吗/嘛/么, a question mark, or a closing 吧).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现需要报告的问题。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-dsh-plugin"、pr_number=53、head_sha="fd56079fa3eef58a4be47a5432f3ac35b461d30b",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 fd56079fa3ee

@forrestlinfeng
forrestlinfeng merged commit 1692fb8 into main Oct 26, 2026
9 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant