This repository was archived by the owner on Nov 10, 2026. It is now read-only.
Repository navigation
Read "1 failed, 0 errors" as a failure and a question as no correction - #53
Merged
Merged
Conversation
Two misreadings, found while porting this logic to the Codex and WorkBuddy plugins: - verificationFailed dropped every output line holding a zero count, so `Tests: 1 failed, 0 errors` lost its failure with the line and read as a pass whenever the exit code was gone (output piped through `tail`). Only the zero counts themselves are dropped now. - looksLikeCorrection took `不行吗?`, `这样不对吧` or `不对吧。` for a correction, which revised a reuse report and dropped a valid distillation candidate. `不行` and `不对` no longer count when what follows asks for an opinion (吗/嘛/么, a question mark, or a closing 吧). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Sentinel 已审核此变更,未发现需要报告的问题。 开发 agent 查询详情: 调用 MCP 工具 由 Sentinel 审核 · 目标提交 fd56079fa3ee |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two misreadings, found while aligning the Codex and WorkBuddy plugins with this one (they already carry the fixed versions).
Check output
verificationFaileddropped every output line that held a zero count, so a mixed summary lost its failure along with the line:It matters whenever the exit code is gone — the reason output is read at all is that dsh's bash reports a failing command piped through
tailas a success. Only the zero counts are removed now (replacewith a global pattern), so0 failed/failures: 0still read as a pass and1 failed, 0 errorsreads as a failure.Corrections
looksLikeCorrectionalready spared行不行/对不对, but took不行吗?,这样不对吧,不对吧。for a correction. A correction revises the reuse report (L3failed) and drops the turn's distillation candidate, so a question cost a valid Gene.不行/不对no longer count when what follows asks for an opinion: 吗/嘛/么, a question mark, or a closing 吧. A plain这样不对,不行,还是报错or不对吧,你再看看is still a correction.Tests
New cases in
test/verification.test.jsandtest/feedback-label.test.js(both fail on main).npm test: 185 pass.🤖 Generated with Claude Code