Skip to content

fix: release unrun distillation claims after a batch failure - #71

Merged
forrestlinfeng merged 4 commits into
EvoMap:mainfrom
imxyanua:codex/release-unrun-distill-claims
Nov 11, 2026
Merged

forrestlinfeng merged 4 commits into
EvoMap:mainfrom
imxyanua:codex/release-unrun-distill-claims

Conversation

@imxyanua

@imxyanua imxyanua commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Summary A failed background distillation could leave later sessions in the same batch claimed by the still-running host. They then stayed busy even after the write failure was repaired. Return every still-matching claim when the batch throws, using the existing range identity guard inside one locked state update. A retry can process the remaining work. ## Evidence - The regression first reproduced a second range still owned by PID 7 after a corpus write failure. - With the fix, both claims are released, neither attempt counter increases, and a retry processes each session once. - Relevant distillation and architecture tests passed 61/61 on Windows Node 22.23.4 and 26.13.0. - The patch also applies to #68 at 119f901. ## Merge Danger Two-way. Scope is background batch failure cleanup. Releasing claims still requires the candidate state file to be writable.

Includes the captured-null owner fix also on #70 so the existing Kimi Windows hook stays within its budget during CI.

@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现需要报告的问题。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=71、head_sha="f057bf72e49d931fa88c7e72eb44d0e0b76c4aa0",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 f057bf72e49d

@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现已核验问题,但发现需要人工确认的风险。

另有 1 个需要人工确认的风险;黄色 advisory 不阻塞合并,建议开发 agent review advisory 评论并逐条确认。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=71、head_sha="5060eefd07666694af9bc02005ba2b1cb5c8cb67",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 5060eefd0766

@evomap-aiqa-bot

Copy link
Copy Markdown

Sentinel 保留了 1 个尚未确认的审核候选。这些黄色条目不阻塞合并;红色 P0/P1 与其他独立硬门禁不受影响。 单一猜测、缺少变更行证据或纯 checklist 的候选会统一降为 P3。
开发 agent:请 review 以下 advisory,并逐条给出“已验证无风险 / 已修复 / 转为后续事项”的结论;不要只做整体确认。

  • [P3] settlement 写入失败会导致已完成的 distillation 被重复执行 — run() 在执行完 distillClaimed() 的外部请求及 corpus/draft 副作用后,才在 finally 中调用 settl...(truncated) · ``lib/app/distill-session.js`` · advisory_a24534271450f9c9fa3dce34`

需要完整证据时,可用行末 finding_key 查询 Sentinel PR review context。

由 Sentinel 审核 · 目标提交 5060eefd0766

forrestlinfeng and others added 2 commits November 11, 2026 10:08
The captured-owner change targeted lib/app/native-turn.js, which EvoMap#68 removed; main's shared late-terminal flow
takes precedence, as the PR description anticipated.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A run that threw already settled its own claim, and earlier runs settled theirs; releasing those again relied on
the claim guard alone and could drop a claim this process took again meanwhile.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cursor

cursor Bot commented Nov 11, 2026

Copy link
Copy Markdown

Bugbot is paused — on-demand spend limit reached

Bugbot uses usage-based billing for this team and has hit its on-demand spend limit.

A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue.

@forrestlinfeng

Copy link
Copy Markdown
Contributor

Merged with maintainer changes: main merged in (dropping the owner-retention commit superseded by #68), and the catch path now releases only the claims that never ran (claims.slice(index + 1) via releaseClaims) — re-settling already-settled claims could release a claim the same process took again meanwhile, e.g. from an explicit distill. Your test still passes. Thanks!

@forrestlinfeng
forrestlinfeng merged commit 3d9e2ce into EvoMap:main Nov 11, 2026
6 checks passed
@evomap-aiqa-bot

evomap-aiqa-bot Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Sentinel 已审核此变更,未发现需要报告的问题。

开发 agent 查询详情: 调用 MCP 工具 sentinel_pr_review_context,传入 owner_repo="evomap/evolver-agent-plugin"、pr_number=71、head_sha="b196e26035656f76a98ee0bd79850134d56d1d32",并按条目追加 finding_id 或 finding_key。

由 Sentinel 审核 · 目标提交 b196e2603565

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants