Repository navigation
fix(ce-sweep): scope merge evidence to full repository identity - #1994
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ce-sweepnow requires a PR candidate to match the checkout’s full host/owner/repository identity before using it as merge evidence. This addresses the P1 found after #1992, where a GitHub.com issue could be falsely resolved using an unrelated, same-numbered Enterprise PR.Follow-up to John Costa’s #1992. Source reads and checkout verification use explicit host-qualified repositories; unresolved identity preserves the item. The fixture now distinguishes same-host successes from foreign-host closing PRs and stored-number collisions on both open and completed issues.
Validation
bun run test: passed after the runner’s automatic serial retry recovered eight subprocess timeouts across five unrelatedce-workfiles.git diff --check: passed. The new explicit-repository command guard fails against merged main.ghchecks confirmed host-qualified repository resolution and PR reads. No live Enterprise mutation was performed.Security Disclosure
Prevents merge evidence from crossing GitHub host/repository boundaries in the skill’s verification contract. Adds read-only source repository resolution and explicit repository selectors; source-side close-out remains subject to standing approval and read-back. The Grok behavior failure above remains a risk for instruction execution.
Agent Disclosure
Co-authored-by: John Costa costajohnt@gmail.com