Add library loading overloads to support linux#7
Open
mberthaud wants to merge 1 commit into
Open
Conversation
mberthaud
changed the title
mberthaud
changed the title
|
I second this, took me a bit to realize what was causing it not to load. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this set of bindings wont work on linux because the Renderdoc native library path and name is effectively hard coded to be a windows specific path.
I added 2 overloads to let caller explicitly put the library name of the renderdoc library (so linux users can explicitly say librenderdoc.so) or just directly pass the handle to the native library they loaded themselves.
the input-less parameter version
public static bool Load(out RenderDoc renderDoc)remains the same and will default to the windows specific path to preserve any old behavior.