Skip to content

security: require distinct permission to enchant another player's item #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jakubk15 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

security: require distinct permission to enchant another player's item #1382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions eternalcore-core/src/main/java/com/eternalcode/core/feature/enchant/EnchantCommand.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import org.bukkit.inventory.PlayerInventory;

@Command(name = "enchant")
@Permission("eternalcore.enchant")
class EnchantCommand {

private final EnchantSettings enchantSettings;
Expand All @@ -28,6 +27,7 @@ class EnchantCommand {
}

@Execute
@Permission("eternalcore.enchant")
@DescriptionDocs(description = "Enchants item in hand", arguments = "<enchantment> <level>")
void execute(@Sender Player player, @Arg Enchantment enchantment, @Arg(EnchantLevelArgument.KEY) int level) {
PlayerInventory playerInventory = player.getInventory();
Expand All @@ -51,7 +51,8 @@ void execute(@Sender Player player, @Arg Enchantment enchantment, @Arg(EnchantLe
}

@Execute
@DescriptionDocs(description = "Enchants item in hand", arguments = "<enchantment> <level> <player>")
@Permission("eternalcore.enchant.other")
@DescriptionDocs(description = "Enchants the item held by the specified player", arguments = "<enchantment> <level> <player>")
void execute(@Sender Player sender, @Arg Enchantment enchantment, @Arg(EnchantLevelArgument.KEY) int level, @Arg Player target) {
PlayerInventory targetInventory = target.getInventory();
ItemStack handItem = targetInventory.getItem(targetInventory.getHeldItemSlot());
Expand Down
Loading