Repository navigation
Feat/disable phantom spawning in vanish - #6646
Open
MochaMilkie wants to merge 4 commits into
Open
MochaMilkie wants to merge 4 commits into
MochaMilkie wants to merge 4 commits into
Conversation
…until last slept when entering vanish, and restore it when leaving vanish
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Information
This PR closes #6645.
Details
Proposed feature:
When a player is vanished, the insomnia/phantom timer should be paused, so phantoms can't spawn for vanished players, regardless of gamemode
This was solved by adding an event listener that cancels any attempt to spawn a phantom that is targeting a vanished player. Then a listener watches for vanish status change and when vanish is enabled the "TIME_SINCE_LAST_REST" is stored in the User object and recalled and applied to .setStatistic() using the value stored when vanish was entered.
Environments tested:
OS: Ubuntu 26.04
Java version: 27
Demonstration:
Tests provided to demonstrate persistent data for the time since the player last slept before and after vanishing.