Skip to content

reliably restore flight on safelogin to prevent airborne players fall… #6590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Rushikumar-06 wants to merge 1 commit into
base: 2.x
Choose a base branch
from
+9 −0
Open

reliably restore flight on safelogin to prevent airborne players fall… #6590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Essentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,15 @@ private void joinFlow(final User user, final long currentTime, final String mess
if (!inWater && LocationUtil.shouldFly(ess, user.getLocation())) {
user.getBase().setAllowFlight(true);
user.getBase().setFlying(true);
// The client sends a flight-abilities sync shortly after joining, which resets the flying state
// and drops the player out of the air. Re-apply the flight state a tick later so it sticks and the
// player keeps flying instead of falling (see the equivalent world-change handling below).
ess.scheduleSyncDelayedTask(() -> {
if (user.getBase().isOnline()) {
user.getBase().setAllowFlight(true);
user.getBase().setFlying(true);
}
}, 1);
if (!restoreFly && ess.getSettings().isSendFlyEnableOnJoin()) {
user.sendTl("flyMode", CommonPlaceholders.enableDisable(user.getSource(), true), user.getDisplayName());
}
Expand Down