Set use_default_shell_env = False on per_file rule - #280
Draft
furtib wants to merge 4 commits into
Draft
Conversation
furtib
added
the
non-functional change ☮️
Szelethus
reviewed
Aug 12, 2026
nettle
requested changes
Aug 12, 2026
| if "PATH" not in env: | ||
| env["PATH"] = "/bin" # NOTE: this is workaround for CodeChecker 6.24.4 | ||
| # NOTE: this is workaround for CodeChecker | ||
| env["PATH"] = "/usr/local/bin:/usr/bin:/bin" |
Collaborator
There was a problem hiding this comment.
This does not look correct to me.
From Bazel perspective we must not do that.
So, why do we?
Contributor
Author
There was a problem hiding this comment.
After further experimentation, it seems like CodeChecker never actually uses any tool from PATH; it just needs it to be set.
I need time for further testing.
furtib
changed the title
furtib
marked this pull request as draft
August 13, 2026 08:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
We want our actions to run without
use_default_shell_env = True.What:
use_default_shell_envto false on per_file rule.Note:
Fails on Jenkins.
Addresses:
none