Skip to content

✨ [feat] pr-body: fold history, read needs-you in the status alert - #90

Merged
EricTechPro merged 2 commits into
mainfrom
feat/pr-body-needs-you-fold
Oct 29, 2026
Merged

EricTechPro merged 2 commits into
mainfrom
feat/pr-body-needs-you-fold

Conversation

@EricTechPro

Copy link
Copy Markdown
Owner

Note

⏳ In review · round 1 · ✅ 4/4 AC · head 8438703

Problem

  • Where: PR bodies the board writes (writing-standard.md § 2, super-board-pr-body.sh)
  • Who: anyone reading a board PR, and the merge gate
  • What happened: the iteration history grows with every lane exit and pushes Risk off the screen; a > needs-you: line inside the status alert, where a blocked card already says "needs you", was not read by the merge gate

Solution

  • History folds in <details><summary>Iteration history</summary>; --skeleton and the run.md template print it folded
  • --append-file keeps a new row inside the fold, above the blank line and </details>; an older unfolded history still appends at its end
  • The merge policy reads > needs-you: <command> inside the status alert as well as the bare line under Risk
  • Ported from the EricOS vendored fork (EricOS 095052b96). What I left out, and why: that patch renamed the blocks to the pr skill template (summary, evidence, merge-danger) and refused the old names. 📝 [docs] pr-body: Door and Blast radius in Risk, before/after in AC proof #75 already put Door and Blast radius in Risk and before/after proof in AC, so merge-danger would duplicate Risk, and summary/evidence would duplicate Problem + Solution and AC + Before | After. I kept 📝 [docs] pr-body: Door and Blast radius in Risk, before/after in AC proof #75's blocks and ported only the two parts nothing on main does: the folded history and the status-alert needs-you. No renamed blocks, so installed lanes and open PR bodies keep working.

Acceptance criteria

  • Merge gate exits 8 on a > needs-you: line in the status alert
    ↳ tests/test-merge-gate.sh case 22b · exit 0 on a2809b6, exit 8 now
  • A history row lands inside the fold, re-append is a no-op
    ↳ tests/test-pr-body.sh · "row lands above " failed on a2809b6, 32/32 now
  • Standard, run.md and skeleton show the history folded
    ↳ tests/test_writing_format.py · 15/16 on a2809b6, 16/16 now
  • Offline safety suite passes
    ↳ bash tests/run-safety.sh · 62 suites pass on macOS
Iteration history
Lane Done Time Details
🔨 builder ✅ Oct 29, 01:29 PDT PR open · 8438703

Risk

🟢 Low · additive: no block renamed, old bodies still append.

  • Door: two-way · revert and history goes back to unfolded
  • Blast radius: PR bodies · new board PRs show history collapsed; a status-alert needs-you now parks the card in 🙋 Blocked

🤖 Generated with Claude Code

EricTechPro and others added 2 commits October 29, 2026 01:27
- merge gate must read a > needs-you: line inside the status alert (exit 8)
- --append-file must keep a row inside a <details> history fold
- skeleton, run.md and the standard must show the history folded

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- writing-standard § 2: history folds in <details>; > needs-you: may sit in the status alert
- pr-body.sh skeleton folds history; --append-file keeps rows above </details>
- merge policy reads > needs-you: lines; run.md template folded
- ported from EricOS 095052b96 minus its block rename (#75 blocks kept)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

EricTechPro added a commit that referenced this pull request Oct 29, 2026
- notes name the VERSION stamp on the public site
- the three EricOS fork ports each get a line with their PR

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EricTechPro added a commit that referenced this pull request Oct 29, 2026
…l map refresh (3.3.0) (#86)

* ✨ [feat] diagrams: security-audit map page and skill-map view

- New /security-audit/ page: Cloudflare's security-audit skill (commit c1c8a8c) on the shared sdlc layout, six phases, 63 parts with when/what/how/behind-the-scenes popovers and line-linked sources.
- layout_sdlc: optional meta.labels, per-stage name and icon, and `parallel` categories (no arrows, no START); SDLC maps rebuilt with identical diagrams.
- Registry, nav, Explore card, 960x600 thumb, Cloudflare logo, pages.yml and README link.
- skill-map.json: external security-audit node in its own root child view (six main steps), re-rendered with 0 crossings; visual tests pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* 🔒 [security] review: run pr-security-review on every PR, install security-audit (3.2.0)

- new bundled skill pr-security-review: Anthropic's local /security-review, prompt verbatim, diff target = PR base (MIT notice + source commit 0c6a49f)
- super-review runs it on every PR; findings are Bug · blocker routed to Super Build
- get.sh and onboard repair fetch cloudflare/security-audit-skill via npx skills; skills-lock.json detection, --no-helper-skills respected
- skills-ready: pr-security-review required in Review, security-audit optional
- super-qa drops its /security-review call; README, main page, skill map, simulator, manifests, onboard.md updated
- tests: get.sh security-audit cases, onboard repair order, readiness entries

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* 🔒 [security] qa: run pr-security-review in QA, not Review

- super-qa runs pr-security-review on every PR as its one security check (folds the old /security-review call)
- each kept finding fails QA: ❌ line, [builder] thread, QA → Ready; skill missing → Block
- super-review drops its security step; the rest of the lane is unchanged
- skills-ready: pr-security-review required in qa, security-audit optional in qa; docs, families, manifests, README synced

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ✨ [feat] collect: hand verified findings to /to-spec and /to-tickets

- new collect_handoff.py: route (to-spec/to-tickets installed?), doc (one grouped findings doc), fork (1–5 → /implement-spec, 6+ → Backlog)
- findings doc at docs/super-board/findings/collect-<YYYY-MM-DD>.md, never overwritten; dry run prints it and writes nothing
- missing /to-spec or /to-tickets, or --direct → today's Backlog filing, with the reason printed; scheduled intake uses --direct
- tests/test_collect_handoff.py; SKILL.md, README, docs flow and AGENTS.md block updated

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* 📝 [docs] routing: write down which path to take, in plain words

- docs/super-board/routing.md: clear idea, foggy idea, bugs → /to-spec → /to-tickets
- build fork: 1–5 tickets → /implement-spec, 6+ → super-board; super-deploy planned
- linked from README and the super-board SKILL.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ✨ [feat] diagrams: two doors and a route fork on the skill map root

- root: Ideas (/grill-me, /wayfinder) and Bugs (/super-collect) meet at /to-spec → /to-tickets; 1–5 tickets → /implement-spec, 6+ → /super-board; planned super-deploy; /security-audit joins the side tools
- pr-security-review moves from super-review to super-qa; super-collect hands a findings doc to /to-spec
- visual template: When · What · How · Example · Behind the scenes tabs, ==highlight==, examples gallery, planned nodes, loop edges, wrapping bullets on phones
- tests: test_visual_* pass (families and main-steps updated for the new root)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* 🔧 [chore] release: 3.3.0 notes and version

- VERSION, skills/super-board/VERSION, plugin.json and README badge → 3.3.0
- RELEASE-NOTES: security check in QA, super-collect planning hand-off, routing doc
- bash tests/run-safety.sh: 63 suites pass

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ✨ [feat] diagrams: four /visual examples in the /visual dialog

- examples: PR description (recap of this branch), super-deploy plan, architecture map, command and script interface
- each has a full-size PNG and a thumb under 100 KB; Pages serves them at /skill-map/examples/
- landing thumb redrawn from the new root view; sync_explore --check passes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* 📝 [docs] diagrams: super-collect hand-off view matches the code

- collect-submit view: findings doc, /to-spec, /to-tickets, then 1–5 to /implement-spec on yes, 6+ to Backlog
- --direct, scheduled runs, GitHub issues and a missing /to-spec or /to-tickets go straight to Backlog
- collect-file node and its edges reworded to match SKILL.md and collect_handoff.py
- re-rendered skill-map.html and index.html; test_visual_*, visual check, sync_explore and run-safety pass

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* 🧪 [test] pages: live site shows repo VERSION, not a typed release

- fails today: index, onboarding and writing-standard hardcode v3.0.2
- pins the dev placeholder, the build stamp and the VERSION path trigger

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* 👷 [ci] pages: stamp VERSION into the site at build

- data-sb-version placeholders read "dev" from disk, stamped at deploy
- pages.yml runs stamp_version.py and redeploys when VERSION changes
- release pill links to releases/latest

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* 📝 [docs] release: 3.3.0 notes list the pages stamp and #88 #89 #90

- notes name the VERSION stamp on the public site
- the three EricOS fork ports each get a line with their PR

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@EricTechPro
EricTechPro merged commit 160b6d5 into main Oct 29, 2026
13 checks passed
@EricTechPro
EricTechPro deleted the feat/pr-body-needs-you-fold branch October 29, 2026 19:24
EricTechPro added a commit that referenced this pull request Oct 29, 2026
- merge: non-Claude hosts merge by hand unless auto is set (#47, 7859103)
- lane: one generic launcher, super-board-lane.sh --backend (cc38679)
- setup: back-to-back fixes no longer crash on the backup folder (76e8ac5)
- #88, #89, #90 were already listed

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant