Skip to content

πŸ› [fix] state: keep board state inside a submodule's own repo - #88

Merged
EricTechPro merged 2 commits into
mainfrom
fix/submodule-board-state
Oct 29, 2026
Merged

EricTechPro merged 2 commits into
mainfrom
fix/submodule-board-state

Conversation

@EricTechPro

Copy link
Copy Markdown
Owner

Note

⏳ In review Β· round 1 Β· βœ… 3/3 AC Β· head aa719e9

Problem

  • Where: a super-board project that is a git submodule (EricOS projects/<name>)
    • a. Install super-board into two sibling submodules
    • b. Let one of them halt on a failed GitHub read
  • Who: anyone running the board inside a submodule
  • What happened: a submodule's common dir is .git/modules/<path>, so "parent of the common dir" put every sibling's github-halt.json and card cache/ in one shared .git/modules/<parent>/.claude/. One project's halt paused the others.

Solution

  • halt_path() (super-board-github-read.py) and cache_dir (super-board-card.sh) use <main checkout>/.claude/super-board/ only when the common dir is <root>/.git; otherwise <git-common-dir>/super-board/
  • Normal repos and linked worktrees keep the old location; SB_GITHUB_HALT_FILE and SB_CARD_CACHE_DIR still override
  • super-board-collect-state.py follows halt_path(), so collector state moves with it
  • run-workflow.md names the submodule location
  • Ported from the EricOS vendored fork (EricOS 3d252cc91); no VERSION or notes change here, they go in the 3.3.0 notes on ✨ [feat] routes: two doors into the board, security check in QA, skill map refresh (3.3.0)Β #86

Acceptance criteria

  • A halt in one submodule leaves its sibling and the parent running
    ↳ test_github_reads.py::test_submodules_keep_their_own_halt Β· failed on a2809b6, passes now
  • A submodule's card cache lives in its own git dir
    ↳ tests/test-card.sh check 10 Β· failed on a2809b6 ("submodule cache not in its own git dir"), 10/10 now
  • Offline safety suite passes
    ↳ bash tests/run-safety.sh Β· 62 suites pass on macOS

Iteration history

Lane Done Time Details
πŸ”¨ builder βœ… Oct 29, 01:29 PDT PR open Β· aa719e9

Risk

🟒 Low · only submodule installs see a new state path.

  • Door: two-way Β· revert and state goes back to the shared folder
  • Blast radius: submodule installs Β· a halt or cache already in the old shared folder is left there to move or delete

πŸ€– Generated with Claude Code

EricTechPro and others added 2 commits October 29, 2026 01:25
- test_github_reads: a halt in projects/a leaves projects/b and the parent running
- test-card: a submodule's card cache lives in its own git dir
- both fail on main: state lands in the shared .git/modules/<parent>/.claude/

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- halt_path() and card cache_dir use <git-common-dir>/super-board/ unless the common dir is <root>/.git
- normal repos and linked worktrees keep <main checkout>/.claude/super-board/
- run-workflow.md names the submodule location; ported from EricOS 3d252cc91

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more β†’

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account β†’

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us β†’

EricTechPro added a commit that referenced this pull request Oct 29, 2026
- notes name the VERSION stamp on the public site
- the three EricOS fork ports each get a line with their PR

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EricTechPro added a commit that referenced this pull request Oct 29, 2026
…l map refresh (3.3.0) (#86)

* ✨ [feat] diagrams: security-audit map page and skill-map view

- New /security-audit/ page: Cloudflare's security-audit skill (commit c1c8a8c) on the shared sdlc layout, six phases, 63 parts with when/what/how/behind-the-scenes popovers and line-linked sources.
- layout_sdlc: optional meta.labels, per-stage name and icon, and `parallel` categories (no arrows, no START); SDLC maps rebuilt with identical diagrams.
- Registry, nav, Explore card, 960x600 thumb, Cloudflare logo, pages.yml and README link.
- skill-map.json: external security-audit node in its own root child view (six main steps), re-rendered with 0 crossings; visual tests pass.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* πŸ”’ [security] review: run pr-security-review on every PR, install security-audit (3.2.0)

- new bundled skill pr-security-review: Anthropic's local /security-review, prompt verbatim, diff target = PR base (MIT notice + source commit 0c6a49f)
- super-review runs it on every PR; findings are Bug Β· blocker routed to Super Build
- get.sh and onboard repair fetch cloudflare/security-audit-skill via npx skills; skills-lock.json detection, --no-helper-skills respected
- skills-ready: pr-security-review required in Review, security-audit optional
- super-qa drops its /security-review call; README, main page, skill map, simulator, manifests, onboard.md updated
- tests: get.sh security-audit cases, onboard repair order, readiness entries

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* πŸ”’ [security] qa: run pr-security-review in QA, not Review

- super-qa runs pr-security-review on every PR as its one security check (folds the old /security-review call)
- each kept finding fails QA: ❌ line, [builder] thread, QA β†’ Ready; skill missing β†’ Block
- super-review drops its security step; the rest of the lane is unchanged
- skills-ready: pr-security-review required in qa, security-audit optional in qa; docs, families, manifests, README synced

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ✨ [feat] collect: hand verified findings to /to-spec and /to-tickets

- new collect_handoff.py: route (to-spec/to-tickets installed?), doc (one grouped findings doc), fork (1–5 β†’ /implement-spec, 6+ β†’ Backlog)
- findings doc at docs/super-board/findings/collect-<YYYY-MM-DD>.md, never overwritten; dry run prints it and writes nothing
- missing /to-spec or /to-tickets, or --direct β†’ today's Backlog filing, with the reason printed; scheduled intake uses --direct
- tests/test_collect_handoff.py; SKILL.md, README, docs flow and AGENTS.md block updated

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* πŸ“ [docs] routing: write down which path to take, in plain words

- docs/super-board/routing.md: clear idea, foggy idea, bugs β†’ /to-spec β†’ /to-tickets
- build fork: 1–5 tickets β†’ /implement-spec, 6+ β†’ super-board; super-deploy planned
- linked from README and the super-board SKILL.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ✨ [feat] diagrams: two doors and a route fork on the skill map root

- root: Ideas (/grill-me, /wayfinder) and Bugs (/super-collect) meet at /to-spec β†’ /to-tickets; 1–5 tickets β†’ /implement-spec, 6+ β†’ /super-board; planned super-deploy; /security-audit joins the side tools
- pr-security-review moves from super-review to super-qa; super-collect hands a findings doc to /to-spec
- visual template: When Β· What Β· How Β· Example Β· Behind the scenes tabs, ==highlight==, examples gallery, planned nodes, loop edges, wrapping bullets on phones
- tests: test_visual_* pass (families and main-steps updated for the new root)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* πŸ”§ [chore] release: 3.3.0 notes and version

- VERSION, skills/super-board/VERSION, plugin.json and README badge β†’ 3.3.0
- RELEASE-NOTES: security check in QA, super-collect planning hand-off, routing doc
- bash tests/run-safety.sh: 63 suites pass

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* ✨ [feat] diagrams: four /visual examples in the /visual dialog

- examples: PR description (recap of this branch), super-deploy plan, architecture map, command and script interface
- each has a full-size PNG and a thumb under 100 KB; Pages serves them at /skill-map/examples/
- landing thumb redrawn from the new root view; sync_explore --check passes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* πŸ“ [docs] diagrams: super-collect hand-off view matches the code

- collect-submit view: findings doc, /to-spec, /to-tickets, then 1–5 to /implement-spec on yes, 6+ to Backlog
- --direct, scheduled runs, GitHub issues and a missing /to-spec or /to-tickets go straight to Backlog
- collect-file node and its edges reworded to match SKILL.md and collect_handoff.py
- re-rendered skill-map.html and index.html; test_visual_*, visual check, sync_explore and run-safety pass

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* πŸ§ͺ [test] pages: live site shows repo VERSION, not a typed release

- fails today: index, onboarding and writing-standard hardcode v3.0.2
- pins the dev placeholder, the build stamp and the VERSION path trigger

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* πŸ‘· [ci] pages: stamp VERSION into the site at build

- data-sb-version placeholders read "dev" from disk, stamped at deploy
- pages.yml runs stamp_version.py and redeploys when VERSION changes
- release pill links to releases/latest

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* πŸ“ [docs] release: 3.3.0 notes list the pages stamp and #88 #89 #90

- notes name the VERSION stamp on the public site
- the three EricOS fork ports each get a line with their PR

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@EricTechPro
EricTechPro merged commit 95ffe9e into main Oct 29, 2026
13 checks passed
@EricTechPro
EricTechPro deleted the fix/submodule-board-state branch October 29, 2026 19:24
EricTechPro added a commit that referenced this pull request Oct 29, 2026
- merge: non-Claude hosts merge by hand unless auto is set (#47, 7859103)
- lane: one generic launcher, super-board-lane.sh --backend (cc38679)
- setup: back-to-back fixes no longer crash on the backup folder (76e8ac5)
- #88, #89, #90 were already listed

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant