Draft
Conversation
2d49f36 to
7602cb7
Compare
d7924d7 to
b6b1f70
Compare
b6b1f70 to
e274a8a
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #72 +/- ##
==========================================
+ Coverage 32.86% 33.10% +0.24%
==========================================
Files 27 26 -1
Lines 5501 5476 -25
Branches 1002 1002
==========================================
+ Hits 1808 1813 +5
+ Misses 3496 3463 -33
- Partials 197 200 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
specifically, resulted in a gridding kernel that did not contain the actual beam
673d12a to
7336c61
Compare
plus fixes to make LWA beams & data work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UVBeam overhaul
Completely overhaul the handling of UVBeam beams.
Note that using this requires having the
fhd_beam_decomposebranch on pyuvdata installed.Note that this currently branches off of #71, so it contains those fixes as well.
fixes #64
Types of Changes
Changelog
Breaking Changes!
New Features
Bug Fixes
Test Changes
Dependency Changes
Version Changes
Build/CI changes
Translation Changes
Checklist
General PR Checklist
New Features Checklist
Existing Tests Checklist
Breaking Changes Checklist
Bug Fixes Checklist
Documentation Checklist
Version Checklist
Build/CI
Translation Checklist