test(cli): simplify churny local coverage#1289
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Local test runs now spend less time re-running the same CLI subprocess fixtures for pipeline artifacts. The pipeline command tests still protect the stable contracts users and downstream tooling depend on: manifest fields, code-grader execution, builtin contains/regex/negate grading,
grading.json,index.jsonl, andbenchmark.jsonoutput.This also moves Dashboard launch-mode and threshold behavior into the docs site so end-user semantics are documented without pinning as many duplicate migration/presentation tests.
What changed
pipeline input,pipeline grade, andpipeline benchsubprocess tests so each fixture run asserts all artifacts from that run.dashboard.threshold, legacy fallback, clamping, and save/migration coverage.apps/web/src/content/docs/docs/tools/dashboard.mdxwith the current Projects-dashboard default and threshold config behavior.Before/after evidence
Pipeline subprocess test reduction against
origin/main:await execabeforeawait execaafterapps/cli/test/commands/eval/pipeline/input.test.tsapps/cli/test/commands/eval/pipeline/grade.test.tsapps/cli/test/commands/eval/pipeline/bench.test.tsapps/cli/test/commands/eval/pipeline/pipeline-e2e.test.tsNet for these files: 22 -> 11 test cases, and 24 -> 13 subprocess invocations.
Timing report for next review
I also timed every test file individually after this change. This is not the same as the full package-level pre-push run, but it identifies where local time is concentrated.
packages/coreapps/clipackages/phoenix-adapterapps/dashboardpackages/evalpluginsSlowest files after this PR:
packages/core/test/evaluation/orchestrator.test.tspackages/core/test/evaluation/workspace/pool-manager.test.tsapps/cli/test/eval.integration.test.tsapps/cli/test/commands/eval/pipeline/input.test.tsapps/cli/test/commands/eval/assert.test.tsapps/cli/test/commands/trend/trend.test.tsapps/cli/test/commands/eval/pipeline/grade.test.tsapps/cli/test/commands/eval/pipeline/pipeline-e2e.test.tsapps/cli/test/commands/eval/pipeline/bench.test.tsapps/cli/test/commands/results/serve.test.tsTiming limitation:
packages/phoenix-adapter/test/agentv-normalize.test.tsfailed only in direct single-file timing because one test resolved an example path outside this worktree. The full repo pre-push test hook passed.Verification
bun run buildpassed. Existing Dashboard bundle-size warning remains.bun test apps/cli/test/commands/eval/pipeline/input.test.ts apps/cli/test/commands/eval/pipeline/grade.test.ts apps/cli/test/commands/eval/pipeline/bench.test.ts apps/cli/test/commands/eval/pipeline/pipeline-e2e.test.tspassed: 11 tests.bun test apps/cli/test/commands/results/studio-config.test.ts apps/cli/test/commands/results/serve.test.ts apps/dashboard/src/lib/navigation.test.tspassed: 86 tests.bun --filter agentv typecheckpassed.bunx biome check <changed files>passed.