Repository navigation
Conversation
tsmbland
force-pushed
the
competitive_algorithm_market_prices
branch
from
November 12, 2026 16:13
8cd1e73 to
9fb2696
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## cumulative_appraisal #1587 +/- ##
========================================================
+ Coverage 82.25% 82.31% +0.06%
========================================================
Files 68 68
Lines 9820 9812 -8
Branches 9820 9812 -8
========================================================
Hits 8077 8077
+ Misses 1464 1456 -8
Partials 279 279 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tsmbland
force-pushed
the
competitive_algorithm_market_prices
branch
4 times, most recently
from
November 16, 2026 10:54
c01f43a to
5a9f0ac
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The price-source change lacks a behavioral regression test using competitive agents and differing market and shadow prices to catch a reversion to shadow-price appraisal.
1 open issue
What changed in this PR
This PR switches competitive-agent investment appraisal from shadow prices to market prices, supporting the planned move towards agent-level operating decisions.
Changes:
- Use market prices for appraisal activity coefficients while retaining fallback incentives.
- Rename
market_coststometric_costsand simplify coefficient calculations. - Update model documentation and schema notes to reflect the new pricing basis.
| File | Description |
|---|---|
src/simulation/investment/competitive/output.rs |
Update the test fixture to use metric_costs. |
src/simulation/investment/competitive/optimisation.rs |
Revise comments about equal-cost solutions. |
src/simulation/investment/competitive/metrics.rs |
Use the renamed metric-cost field. |
src/simulation/investment/competitive/coefficients.rs |
Calculate activity coefficients from market prices and simplify metric costs. |
src/simulation/investment/competitive.rs |
Pass market and fallback prices explicitly to coefficient calculation. |
schemas/input/model.yaml |
Describe fallback pricing relative to market prices. |
docs/model/dispatch_optimisation.md |
Remove shadow-price appraisal claims. |
docs/model/agents.md |
Align appraisal explanations and equations with market pricing. |
Review effort: Balanced
| model, | ||
| objective_type, | ||
| &opt_assets, | ||
| &prices.market, |
tsmbland
force-pushed
the
competitive_algorithm_market_prices
branch
3 times, most recently
from
November 16, 2026 13:32
6ac8210 to
8c5771f
Compare
tsmbland
marked this pull request as ready for review
November 16, 2026 13:34
tsmbland
force-pushed
the
competitive_algorithm_market_prices
branch
from
November 16, 2026 15:00
8c5771f to
3d79213
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Modifying the
competitiveagent algorithm to use market prices instead of shadow prices. We want agents to be able to operate assets however they want, and it's market prices that matter. (Shadow prices are necessary if the goal is to minimise total system cost, but we're moving away from that)Fixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks