Repository navigation
Conversation
tsmbland
force-pushed
the
prices_refactor
branch
from
November 10, 2026 16:04
5849c63 to
e3743c4
Compare
tsmbland
force-pushed
the
prices_refactor
branch
5 times, most recently
from
November 16, 2026 10:54
dbbad15 to
24ff79a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## activities_from_investment #1586 +/- ##
==============================================================
- Coverage 82.15% 82.02% -0.13%
==============================================================
Files 69 69
Lines 9998 10037 +39
Branches 9998 10037 +39
==============================================================
+ Hits 8214 8233 +19
- Misses 1507 1527 +20
Partials 277 277 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
tsmbland
force-pushed
the
prices_refactor
branch
3 times, most recently
from
November 16, 2026 13:32
fd9df9b to
240054f
Compare
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The pricing-input refactor has no active review issues.
No open issues 🎉
What changed in this PR
Decouples commodity price calculation from dispatch solutions, preparing the simulation to calculate prices from agent-level activities.
Changes:
- Makes the core pricing function accept activities, candidates, shadow prices, and activity duals directly.
- Adds solution-to-map helpers and a wrapper for dispatch-based pricing.
- Updates simulation and benchmark callers to use the wrapper.
| File | Description |
|---|---|
src/simulation/prices.rs |
Refactors pricing inputs and adds the dispatch-solution wrapper. |
src/simulation/optimisation.rs |
Adds activity and dual map extraction helpers. |
src/simulation/activity.rs |
Defines the activity-dual map type. |
src/simulation.rs |
Updates dispatch pricing calls to use the wrapper. |
benches/assets.rs |
Updates benchmark seed-price calculation to use the wrapper. |
Review effort: Balanced
tsmbland
force-pushed
the
prices_refactor
branch
from
November 16, 2026 15:00
240054f to
704bdb8
Compare
tsmbland
marked this pull request as ready for review
November 16, 2026 15:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This uncouples price calculation from full-system dispatch, so we can eventually calculate prices using agent-level activities
Fixes # (issue)
Type of change
Key checklist
$ cargo test$ cargo docpresent in the previous release
Further checks