Skip to content

update#988

Open
xuhuanzy wants to merge 4 commits intoEmmyLuaLs:mainfrom
xuhuanzy:update
Open

update#988
xuhuanzy wants to merge 4 commits intoEmmyLuaLs:mainfrom
xuhuanzy:update

Conversation

@xuhuanzy
Copy link
Member

  1. 支持注解的索引访问符

允许
```lua
        ---@type T[1]
        ---@type T["a"]
        ---@type T[A]
```
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

此拉取请求引入了对LuaDoc类型注解中索引访问的支持。这一增强功能允许更具表达性和精确性的类型定义,尤其是在处理泛型类型或访问类或表类型的特定属性时。这些更改包括修改LuaDoc解析器以正确解释新语法,以及更新类型分析引擎以准确解析这些索引类型,从而确保健壮的类型检查。

Highlights

  • 新增LuaDoc注解索引访问支持: 系统现在能够正确解析和解释 Foo[K] 这样的类型,从而实现更精确的类型定义。
  • 更新解析器以支持类型索引访问: LuaDoc解析器现在能够正确识别各种形式的类型索引访问(如 T[1]T["a"]T[A])。
  • 为类型索引访问添加新的测试用例: 增加了全面的测试,以验证注解中索引访问的解析和类型解析的正确性。

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@xuhuanzy xuhuanzy linked an issue Mar 19, 2026 that may be closed by this pull request
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

此拉取请求引入了对类型注解中索引访问符(例如 Foo[K])的支持。通过修改解析器以正确识别和解析类型定义中的 TypeIndexAccess 语法来实现。新增了 test_issue_986 测试用例来验证代码分析编译中的此功能,并在解析器的语法测试中添加了 test_type_index_accessparse_suffixed_type 函数中处理 TkLeftBracket 的解析逻辑得到了简化和统一,以正确识别字符串、整数或名称字面量键的 TypeIndexAccess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic indexed access T[K] resolves to any

1 participant