Repository navigation
fix(lint): ez 1.16.0, bolt 1.65.0; clear bolt findings - #62
Merged
Merged
Conversation
Pin bolt v1.65.0 (bolt check is the lint command) and move the ez flake input to v1.16.0, whose mkLint runs bolt check for that pin. bolt.bend drops the retired param setting. bend stays at 222de99 (2.0.40). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bolt check is clean with every group at error; the closed, coverage and wrap overrides that held findings at warn are gone. Encoder and decoder output is byte-identical: a native bench build before and after encodes and decodes the same WAV and shine MP3 files to the same bytes. Errors: - S009 x14: side.tail takes the packed table selects; sr.* carries the search window and the best fit so far as Sw and Bs; an.blk and cs.pack become list literals; d9.build splits into d9.even and d9.odd, and d9.from takes those two parts. - S011 x3: hf.go, c1.go and guid.is match their two scrutinees together. Warnings: - S003 x48: one parameter per line (bolt format), and the long proof hypotheses name their check (whole.ok, wf.ok, code.of). - L001 x9: the clip readers are reached by quantified laws; the unused bit reader in src/mp3.bend (Bit, Br, Acc and their defs) is deleted. - L002 x99: 42 closed laws become 38 quantified ones (clip fields, count, concat, fill, binary32 clamping, header fields, the 44100 Hz pad cycle, encoder headers over the pad bit, the RIFF ids of every encoded file, WAV refusals, and WAV reads for every tail after the file). The other 57 checked single fixtures (MP3 decode of fixture frames, silent frames, WAV round trips and byte layouts, Table B.8 rows) and are deleted, with the fixture defs only they used; the bench's wave check still compares those behaviours with ffmpeg. count.of branches on a Bool so its law can be proved. LAWS.bend, the law files and the README say which statements are laws. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 67 closed laws that the lint fix deleted or replaced were each a single input with a known output. They run again as tests/fixtures.bend, one `ok <name>` line per fixture against its `#|` trailer, with the exact expected values the laws stated: MP3 decode of the hand-made frames (count1, CRC, ID3v2 and its footer, Xing and Info, junk, partial frames, Layer I/II, joint stereo, reservoir, scale-factor bits, short blocks, overruns), silent frames both ways, encode refusals, binary32 clamping, the Table B.8 rows, frame room at the bit budget, fill and trim, and WAV byte layouts, round trips, streamed and truncated files and chunk ids. `ez test` runs it, and a new `fixtures` flake check runs it with bend and diffs the output against the trailer, so `nix flake check` fails if any fixture regresses. The fixture data lives in fixtures/, outside tests/, since `ez test` runs every .bend under tests/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ngngardner
enabled auto-merge (squash)
November 16, 2026 16:28
ngngardner
disabled auto-merge
November 16, 2026 16:29
ngngardner
enabled auto-merge (squash)
November 16, 2026 16:29
[tools.bolt] v1.66.0 (bolt#398: a list-literal data table isn't measured by S010). ci.yml at actions 4ea982d: macOS runs outside the required check (actions#16), and only when C/JS effect code, the flake or ez's lock changes (actions#17). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What moved
[tools.bolt]v1.27.0 → v1.65.0 (bolt checkis now the lint command); flake inputez→ v1.16.0 (c9f4855), whose mkLint runsbolt checkfor that pin. bend stays at 222de99 (2.0.40).paramsetting is removed (C011), and theclosed,coverageandwrapoverrides that held findings at warn are removed too. Every group is at error andbolt checkprintsclean.Rules fixed
Errors:
side.tailtakes the packed table selects; thesr.*gain search carries its window and best fit asSw/Bs;an.blkandcs.packbecome list literals;d9.buildis split intod9.even/d9.odd.hf.go,c1.go,guid.ismatch their two scrutinees together.paramremoved from bolt.bend.Warnings:
f32,rate,channels,format,count,concat) are reached by quantified laws. The unused bit reader insrc/mp3.bend(Bit,Br,Accand its defs) is deleted.fmtids for every encoded file, WAV refusals (non-RIFF, zero rate, wide s16, sizes past a U32), and WAV reads for every tail after the file. The other 57 each checked a single fixture, so they are no longer laws. They now run as tests (see below).count.ofnow branches on a Bool so its law can be proved. LAWS.bend, the law files and the README say which statements are laws and point at the fixture tests.Fixtures as tests
Every closed law this PR removed is back as a test. That is the 57 deleted ones plus the 10 whose names changed when they were quantified (fill, RIFF tags, clamp words,
wav_rate_wraps), so 67 in all. They live intests/fixtures.bend, which prints oneok <name>line per fixture against its#|trailer and uses the exact expected values the laws stated. The fixture data is infixtures/.ez testruns the file, and a newchecks.<system>.fixturesruns it with bend and diffs the output against the trailer, sonix flake checkfails if any fixture regresses. I checked this by changing one expected value and confirming that fixture printed FAIL.Some of these the bench
wavecheck already covered against ffmpeg or Python'swave, though often on similar inputs rather than the exact fixture:That is about 24 of the 67. The rest had no CI check until now:
linesformswav_s16_wide,wav_no_frames_round, streamed, truncated andwav_rate_wrapsPublic API findings
None. Every finding was in internal helpers, and no public def changed.
Warnings remaining
None.
Gate
bolt check(1.65.0):cleanbend PROOF.bendon bend 2.0.40:ALL PROOFS CHECK;ez prove(1.16.0): PASS 1/1;bend main.bend --check-only: ALL PROOFS CHECKnix flake check -Lon x86_64-linux: passes (proofs, lint, fixtures 67/67, wave compare 0 hard failures of 49)ez test: PASS 1/1🤖 Generated with Claude Code