Repository navigation
Make SQL namespace creation atomic and report conflicts - #136
Merged
osipovartem merged 3 commits intoOct 26, 2026
Merged
Conversation
osipovartem
marked this pull request as draft
October 26, 2026 03:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQL namespaces were represented only by property rows. Duplicate CREATE with disjoint property keys could succeed, empty namespaces required a synthetic property, and concurrent updates/drops could lose identity. SQL values were also interpolated into queries.
Change
iceberg_namespacesprimary-key row. CREATE writes identity and properties atomically and reports unique violations asCommitConflict.existsmarker without deleting user data; explicitly updatedexistsbecomes visible.Verification
create_schema17/17 and catalogif_not_exists_2/2 passed against the equivalent runtime code.-D warnings,cargo fmt --all --check, andgit diff --checkpassed.Concurrent old-version writers should be quiesced during rollout. This migration reads old property-only catalogs but is not a mixed-version write protocol.