Fix C++11 build failure in destroy_at#88
Open
kiranj26 wants to merge 1 commit intoEmbedded-AMS:developfrom
Open
Fix C++11 build failure in destroy_at#88kiranj26 wants to merge 1 commit intoEmbedded-AMS:developfrom
kiranj26 wants to merge 1 commit intoEmbedded-AMS:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a C++11 compatibility issue in
src/Defines.h.In the C++11 code path,
destroy_atwas declared as:constexpr void destroy_at(T* p)With Apple Clang (C++11), this fails to compile because
constexprfunctions in C++11 cannot havevoidreturn type.This change updates the C++11 overload to:
inline void destroy_at(T* p)C++14 and C++17+ paths are unchanged.
Why this change
build_test.shfails on C++11 toolchains due to theconstexpr voiddeclaration, which blocks normal development and CI on affected compilers.Validation
./build_test.shsuccessfully after the change../build/test/test_EmbeddedProtosuccessfully (155tests passed).Scope
src/Defines.hIssue
Closes #89