pset: fix pegin/issuance flag handling in extract_tx#265
Open
apoelstra wants to merge 2 commits intoElementsProject:masterfrom
Open
pset: fix pegin/issuance flag handling in extract_tx#265apoelstra wants to merge 2 commits intoElementsProject:masterfrom
apoelstra wants to merge 2 commits intoElementsProject:masterfrom
Conversation
We have a convention that in memory, we don't have the pegin or witness flags on the input index for TxIn, but we *do* keep these around in the Psbt::Input map.
… witnesses This test case was written by Claude and (fairly heavily) edited by me to add the PSBT round-tripping and to tighten up some checks. Originally we thought the bug was related to witness encoding, so the test covers various permutations of null witnesses. Actually this was a red herring and the bug was just about the pegin flag in the input index being preserved across PSBTs. But I left most of the witness-deleting test in place anyway because it seems potentially useful.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When extracting a transaction we were leaving bits set in the input indices, which is incorrect and leads to serialization round-tripping bugs.
Fixes #263.