reckless: rust rewrite#9239
Conversation
Changelog-None
vincenzopalazzo
left a comment
There was a problem hiding this comment.
Nice to see that the manifest idea is taking over. Hope you are also using git for versioning, otherwise this would be another good thing to take from https://github.com/coffee-tools/coffee
There was a problem hiding this comment.
Would be nice to reference the original reference implementation https://coffee-docs.netlify.app/support-coffee
There was a problem hiding this comment.
Would be nice to reference the original reference implementation https://coffee-docs.netlify.app/support-coffee
I was planning on giving full credit for the manifest/tip function to coffee in the README. But i want to lock down the functionality first before writing documentation.
There was a problem hiding this comment.
to save credit was also good to just include coffee, I do not think there are more features than coffee, we were also supporting ws (palanning to) to support interactive UX inside the web applications
But these days cloning is easy!
If you mean installing a plugin with a git ref then yes, that is supported. |
Yeah, otherwise it's insanity! Nice, it would be nice to have two lines that reference coffee because the development died because Blockstream was moving to reckless. Referencing a good idea is what is left in this AI era, where rebuilding is easy |
Not ready for code review yet, we have not decided on some important aspects. Right now it is a drop-in replacement of the python reckless version.
Should
Fixes: #8439
Fixes: #8761
Fixes: #8775
Fixes: #8776
Fixes: #8794
and should supercede #8630
Key differences:
reckless-diris a proper plugin option now--jsonoptionlistavailable, an array of strings is just not nice heremanifest.json