CI: Update Mac CI to use gmake#8957
Merged
Merged
Conversation
ddustin
force-pushed
the
ddustin/gmake_on_ci
branch
10 times, most recently
from
25a051f to
529ea39
Compare
daywalker90
force-pushed
the
ddustin/gmake_on_ci
branch
from
529ea39 to
1546b3c
Compare
daywalker90
reviewed
May 25, 2026
| TMPOBJFILE=$CONFIG_VAR_FILE.$$.o | ||
|
|
||
| echo "int foo(void); int foo(void) { return 0; }" > $TMPCFILE | ||
| $1 $2 -ffunction-sections -Wl,--gc-sections -c $TMPCFILE -o $TMPOBJFILE |
Collaborator
Author
There was a problem hiding this comment.
Nice catch, didn't mean to commit that!
Collaborator
There was a problem hiding this comment.
Turns out it was the right call. #9072 removes -c.
madelinevibes
added
the
Status::Ready for Review
`gmake` is kept up to date while `make` is apple’s built in mac that is not updated and very old at this point. Changelog-None
ddustin
force-pushed
the
ddustin/gmake_on_ci
branch
from
1546b3c to
3d1bf43
Compare
daywalker90
approved these changes
Jun 15, 2026
Collaborator
|
lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gmakeis kept up to date whilemakeis apple’s built in mac that is not updated and very old at this point.