Update pnpm/action-setup and upload-artifact to their Node 24 releases - #6916
Conversation
Both actions still declared runs.using node20, so every workflow run carried the Node 20 deprecation annotation even though the runner already forces them onto Node 24. The warning keys off the declared runtime, so only a version bump clears it: pnpm/action-setup gained node24 in v5.0.0 and upload-artifact in v6.0.0, with v5 of the latter still on node20. Closes Effect-TS#6915 Signed-off-by: C. Spencer Beggs <spencer@beggs.codes>
|
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — version bumps for two GitHub Actions to their Node 24 releases to silence the Node.js 20 is deprecated annotations.
pnpm/action-setup@v4→@v6in.github/actions/setup/action.yaml: v6 adds pnpm v11 support on top of the node24 runtime from v5; the action is invoked with no inputs and resolves the version frompackageManager, so the input surface delta is irrelevant.actions/upload-artifact@v4→@v6in.github/workflows/check.yml: v6 is the first node24 release (v5 remained node20). Runner compatibility is satisfied (ubuntu-latest≥ 2.327.1), and thename,path,if-no-files-foundinputs are unchanged. Thedownload-artifact@v8consumer is already node24.
DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏
|
Note on the one red check, so it does not cost a reviewer time.
This PR changes two The thing this PR is actually meant to do did verify, on a run that completed rather than being superseded:
The same base commit ( I can push an empty commit to re-roll it if that is useful. |
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
3 participants
Closes #6915.
Every workflow run currently carries
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/upload-artifact@v4, pnpm/action-setup@v4.The annotation keys off the
runs.usingvalue each action declares in its ownaction.yml, not off the Node version the runner ends up using — the runner log alongside it already says "This workflow is running with Node 24 by default". SoFORCE_JAVASCRIPT_ACTIONS_TO_NODE24=truedoes not help; that variable was the opt-in from before the runner default flipped. Bumping the two actions is what clears it.pnpm/action-setup@v4->v6. v5.0.0 moved it to node24 and v6.0.0 added pnpm v11 support; neither changed the input surface. It is invoked here with no inputs and resolves the version frompackageManagerin the rootpackage.json.actions/upload-artifact@v4->v6. v6.0.0 is the first node24 release — v5 is still node20, so a bump to v5 would not have cleared the warning. Thename,pathandif-no-files-foundinputs used here are unchanged. v6 requires Actions Runner >= 2.327.1; the deprecation notice cites hosted runners at v2.328.0 and every job here isruns-on: ubuntu-latest. Theactions/download-artifact@v8consumer inbundle-comment.ymlis unaffected.Every other action in
.github/already declares node24:actions/checkout@v6,actions/setup-node@v6,actions/download-artifact@v8,changesets/action@v1,denoland/setup-deno@v2,oven-sh/setup-bun@v2, the threepeter-evans/*actions, andpullfrog/pullfrog@v0.No changeset: this touches CI configuration only, with no runtime or exported API change.
The verification for this is CI itself — the annotation should be absent from this PR's run. I could not check the
upload-artifactpath locally, and it only executes onpull_requestevents, so this PR's Bundle job is the first real exercise of it.Signed-off-by: C. Spencer Beggs spencer@beggs.codes