Change Number.parse to parseFloat in schema migration

[danielo515]

Type

• Refactor
• Feature
• Bug Fix
• Optimization
• Documentation Update

Description

Change Number.parse to parseFloat in schema migration
Used parseFloat to make it consistent with previous V3 example
Number.parse does not exist.

Related

NOne

• Related Issue #
• Closes #

[changeset-bot]

⚠️ No Changeset found

Latest commit: ebecf28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pullfrog]

ℹ️ No critical issues — one minor observation inline.

Reviewed changes

• Fixed non-existent Number.parse → parseFloat — corrects the v4 migration example to use a valid function name, consistent with the v3 example above it.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏}

[github-actions]

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name	Current Size	Previous Size	Difference
basic.ts	6.63 KB	6.63 KB	0.00 KB (0.00%)
batching.ts	9.42 KB	9.42 KB	0.00 KB (0.00%)
brand.ts	6.31 KB	6.31 KB	0.00 KB (0.00%)
cache.ts	10.18 KB	10.18 KB	0.00 KB (0.00%)
config.ts	20.04 KB	20.04 KB	0.00 KB (0.00%)
differ.ts	19.93 KB	19.93 KB	0.00 KB (0.00%)
http-client.ts	21.03 KB	21.03 KB	0.00 KB (0.00%)
logger.ts	10.34 KB	10.34 KB	0.00 KB (0.00%)
metric.ts	8.55 KB	8.55 KB	0.00 KB (0.00%)
optic.ts	7.33 KB	7.33 KB	0.00 KB (0.00%)
pubsub.ts	14.47 KB	14.47 KB	0.00 KB (0.00%)
queue.ts	11.15 KB	11.15 KB	0.00 KB (0.00%)
schedule.ts	10.33 KB	10.33 KB	0.00 KB (0.00%)
schema-class.ts	18.86 KB	18.86 KB	0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts	28.67 KB	28.67 KB	0.00 KB (0.00%)
schema-representation-roundtrip.ts	24.99 KB	24.99 KB	0.00 KB (0.00%)
schema-string-transformation.ts	13.00 KB	13.00 KB	0.00 KB (0.00%)
schema-string.ts	10.65 KB	10.65 KB	0.00 KB (0.00%)
schema-template-literal.ts	14.85 KB	14.85 KB	0.00 KB (0.00%)
schema-toArbitraryLazy.ts	21.66 KB	21.66 KB	0.00 KB (0.00%)
schema-toCodeDocument.ts	24.08 KB	24.08 KB	0.00 KB (0.00%)
schema-toCodecJson.ts	18.91 KB	18.91 KB	0.00 KB (0.00%)
schema-toEquivalence.ts	18.73 KB	18.73 KB	0.00 KB (0.00%)
schema-toFormatter.ts	18.59 KB	18.59 KB	0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts	22.33 KB	22.33 KB	0.00 KB (0.00%)
schema-toRepresentation.ts	19.25 KB	19.25 KB	0.00 KB (0.00%)
schema.ts	18.12 KB	18.12 KB	0.00 KB (0.00%)
stm.ts	12.12 KB	12.12 KB	0.00 KB (0.00%)
stream.ts	9.37 KB	9.37 KB	0.00 KB (0.00%)

[pullfrog]

Important

The fix for the prior === undefined feedback introduced a variable name mismatch that breaks the example.

Reviewed changes

• Switched === undefined check to isNaN(parsed) — addresses the prior review comment that parseFloat returns NaN, not undefined.

  ^{｜ Fix all ➔ ｜ Fix 👍s ➔ ｜ View workflow run ｜ Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏}

[pullfrog]

✅ No new issues found.

Reviewed changes

• Renamed variable n → parsed — fixes the variable name mismatch flagged in the prior review, making the parseFloat assignment and isNaN check consistent with each other and with the v3 example.

  ^{｜ View workflow run ｜ Using DeepSeek Pro (free via Pullfrog for OSS) (Kimi K2 not used — the program covers this model; add its provider key to run your pick) ｜ 𝕏}

[gcanti]

I think it was parse from the Number.ts module. In any case, the example needs to be updated because it now returns None instead of undefined.