Skip to content

Fix child workflow fan-out inside activities#6258

Open
mikearnaldi wants to merge 2 commits into
mainfrom
repro/workflow-parallel-activity-test
Open

Fix child workflow fan-out inside activities#6258
mikearnaldi wants to merge 2 commits into
mainfrom
repro/workflow-parallel-activity-test

Conversation

@mikearnaldi
Copy link
Copy Markdown
Member

Summary

  • add a regression test for parallel child workflows launched inside an activity
  • mark activity execution internally so nested child workflow awaits do not suspend the activity fiber
  • wait on suspended child workflow results using the existing workflow suspended retry schedule

Validation

  • pnpm test run packages/cluster/test/ClusterWorkflowEngine.test.ts
  • pnpm test run packages/workflow/test/WorkflowEngine.test.ts
  • pnpm lint-fix
  • pnpm check
  • pnpm build
  • pnpm docgen

@mikearnaldi mikearnaldi requested a review from tim-smart as a code owner June 4, 2026 17:06
@github-project-automation github-project-automation Bot moved this to Discussion Ongoing in PR Backlog Jun 4, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 4, 2026

🦋 Changeset detected

Latest commit: 582afd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@effect/workflow Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

parent: Option.getOrUndefined(parentInstance)
})
if (Option.isSome(parentInstance)) {
if (currentActivityExecution) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would keep the activity in-memory even if the workflow suspends for long time. Will need to find another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Discussion Ongoing

Development

Successfully merging this pull request may close these issues.

2 participants