Skip to content

🐛 Bump js-yaml to 4.3.2 and Storybook to 10.6.2, drop unused smol-toml - #139

Merged
Miyamura80 merged 23 commits into
mainfrom
claude/festive-cori-e6o9o8
Nov 11, 2026
Merged

Miyamura80 merged 23 commits into
mainfrom
claude/festive-cori-e6o9o8

Conversation

@Miyamura80

@Miyamura80 Miyamura80 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Security dependency fix. Nothing else changes.

Package From To Advisories cleared
js-yaml (lockfile, transitive via electron-builder / electron-updater) 4.3.0 4.3.2 GHSA-2883-xcg3-v3hh (CVE-2026-84375), GHSA-5p4m-2wfm-xmqj
js-yaml (pinned in desktop-release.yml and desktop-release-demo.yml for merge-win-update-manifest.cjs) 4.1.0 4.3.2 GHSA-2883-xcg3-v3hh, GHSA-52cp-r559-cp3m, GHSA-5p4m-2wfm-xmqj, GHSA-h67p-54hq-rp68, GHSA-mh29-5h37-fv8m
storybook + @storybook/* (dev only, desktop + shared) 10.5.7 10.6.2 GHSA-f2ph-cmg5-wxc8 (CVE-2026-114125), GHSA-px85-f4q5-jh77 (CVE-2026-114126)
smol-toml (direct dep of packages/desktop) ^1.6.1 removed n/a (unused: no imports anywhere)

Notes:

  • Each target is the smallest version that fixes the advisory (js-yaml patch bump, Storybook 10.5 to 10.6 minor, no 10.5.x fix exists). Both are older than 14 days (js-yaml 4.3.2: 2026-08-26, Storybook 10.6.2: 2026-10-12) and match 0 advisories in a local copy of the OSV npm dump. Publishers are unchanged (js-yaml: same maintainer account; Storybook: same GitHub Actions trusted publisher with provenance). No 2026 compromise reports found for either.
  • The lockfile was regenerated with npm (npm install --package-lock-only --before=2026-10-13, then npm update js-yaml), so every re-resolved transitive is also at least 14 days old. A few Storybook transitives moved with it (react-docgen, resolve, @testing-library/user-event, oxc-resolver). The new lock introduces no new OSV matches.
  • smol-toml 1.7.0 stays in the tree as a transitive dev dependency of knip, and still matches GHSA-7w5x-hrqm-74c2 and GHSA-r4xh-jqrq-34v2. That needs a knip bump and is out of scope here.

Test plan

  • npm ci from root
  • shared: typecheck, lint, format:check, knip, test (62 passed), build, build-storybook
  • desktop: typecheck, test:coverage (210 passed), build
  • root: pinned-refs:check, version:check
  • desktop build-storybook fails here, but it also fails on main in this sandbox (unresolved packages/packages/shared path). It is not part of desktop CI.
  • Next release run: confirm the Windows latest.yml merge step still works with js-yaml 4.3.2

Generated by Claude Code


Summary by cubic

Security dependency bump: js-yaml to 4.3.2 and Storybook to 10.6.2 clear multiple advisories, and the unused direct smol-toml dependency is dropped from packages/desktop. No behavior changes.

Notes

Written for commit 5f634f0. Summary will update on new commits.

View guided diff Turn on auto-fix

claude added 23 commits October 21, 2026 12:21
Bump the uv version staged into the Windows desktop installer
(resources/runtimes/uv) from 0.11.21 to 0.13.4. uv 0.13.4 ships
webpki-root-certs 1.0.10, which drops the compromised eMudhra root.
The script already verifies each zip against the release's .sha256
file; both 0.13.4 Windows assets were downloaded and checked.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
webpki-roots 1.0.10 drops emSign ECC Root CA - G3 from the bundled trust
store after the eMudhra intermediate key compromise. stdiod 1.0.7 -> 1.0.10
(the 0.26.11 shim depends on ^1 and now resolves to 1.0.10), detectord
1.0.8 -> 1.0.10. Lockfile-only change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
Electron 43.8.1 applies the certificate SPKI blocklist to Node and adds
the 8 compromised emSign intermediate keys; 43.8.3 is the latest 43-x-y
patch (adds a 64-change Chromium/V8 security cherry-pick). Range raised
to ^43.8.3 so installs cannot resolve below the patched build
(43.2.0 -> 43.8.3). npm also resynced the stale desktop workspace version
in package-lock.json (0.6.9 -> 0.6.14, matching package.json).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
electron-builder packages the runtime pinned by electronVersion, not the
resolved electron devDependency, so installers were still shipping 40.8.0
(EOL, no eMudhra fix) while dev and e2e already ran on 43.x. Pin the
packaged runtime to 43.8.3, matching the devDependency. The desktop app
has no runtime native modules, so no ABI rebuild is involved.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
0.103.16 rejects certificate paths containing the compromised emSign
intermediates; cargo-deny flags earlier versions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
Every GitHub Actions `uses:` is now pinned to a 40-character commit sha with
the human-readable tag kept as a comment. Each sha was resolved from the tag
and independently verified, so a moved or rewritten tag can no longer swap in
different code.

- dtolnay/rust-toolchain is pinned to a master commit, which no longer
  carries the channel in the ref, so every step now passes
  `toolchain: stable` explicitly.
- actions/setup-node v6 steps move to v6.5.0 alongside the v7 pins.
- scripts/check_immutable_refs.py fails if any Dockerfile or workflow uses a
  mutable image tag or action ref; it runs in the new "Pinned refs" workflow
  on every pull request and push to main, and locally via
  `npm run pinned-refs:check`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
The guard now clears a pin-exempt at a blank line, joins continuation
lines like Docker (honouring a `# escape=` directive), requires a bare
or docker:// runs.image to be pinned, reads flow-style and spaced YAML
keys, checks every ref on a line and requires owner/repo@<sha>. On pull
requests the workflow runs the base branch's copy of the checker.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
cargo-deny fails on tokio 1.52.1 (AsyncFd constructors violate I/O
safety); 1.53.3 is the patched release on this line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
FROM now resolves only global ARGs (declared before the first FROM), and
each stage starts empty, seeing a global value only by redeclaring it
without a default, so a pinned stage-level ARG can no longer mask a
mutable global default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`ARG NAME=` now sets the value to "" instead of leaving an earlier
default in place, so the empty value fails closed as untagged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
Continuation lines of an open `{ ... }` / `[ ... ]` keep flow-style
parsing, so `uses:` after another key on such a line is checked, and a
`*version:` whose value `latest` starts on the next line is flagged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
A `*version:` key inside a flow collection whose value starts on the
next line is now checked too, and comment lines before the value are
skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
…blowup

- An anchor or tag before a block key (`- &step uses: x`, `- !!str uses: x`,
  `{ &k uses: x }`) no longer hides the key from the check.
- Verbatim tags with commas (`!<tag:yaml.org,2002:seq> [...]`) now open a
  flow collection.
- Each node property must end at whitespace or a bracket, so a run like
  `&&&&x` has one split instead of exponentially many (the old pattern hung
  on 30 characters).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`!<[^>]*>` ran to the end of the line from every comma when the tag was
never closed, so a flow line of repeated `,!<` was quadratic (32k repeats
took 8s). YAML verbatim tags hold URI characters only, so the tag now
stops at whitespace or another `<`; the same line takes 0.04s.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`bun-version: &v latest` (and `&v` with `latest` on the next line) slipped
past the `latest` check because the value was taken to be `&v`, and
`uses: &pin owner/repo@<sha>` was wrongly rejected for the same reason.
Node properties after the colon are now skipped before the value is read,
on the key's own line and on the line below it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`container: &c` followed by `{ image: <pinned> }` on the next line was
read as a scalar image and rejected. A continuation that opens a `{` or
`[` collection is now left to the per-line flow scanner, which already
checks the keys inside it, so a mutable image there is still flagged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
Bump electron ^43.8.3 -> ^43.8.6 (lockfile regenerated with npm); 43.8.4
updated the bundled Node.js to v24.22.1, which fixes the Brotli decoder
out-of-bounds write. Bump CI bun-version 1.4.3 -> 1.4.4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
The desktop SAML/SSO window (ipc/ipcHandlers.ts) renders third-party IdP
pages, the one surface where renderer bugs from the Chromium 157 batch
(sandbox escape, V8 type confusion) are reachable.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
- js-yaml 4.3.0 -> 4.3.2 (lockfile, via electron-builder/electron-updater)
  and the release workflows' pinned js-yaml@4.1.0 -> 4.3.2. Clears
  GHSA-2883-xcg3-v3hh, GHSA-5p4m-2wfm-xmqj (and for 4.1.0 also
  GHSA-52cp-r559-cp3m, GHSA-h67p-54hq-rp68, GHSA-mh29-5h37-fv8m).
- storybook + @storybook/* 10.5.7 -> 10.6.2 (dev only). Clears
  GHSA-f2ph-cmg5-wxc8 and GHSA-px85-f4q5-jh77.
- Remove the direct smol-toml dependency from packages/desktop; nothing
  imports it. knip still pulls it in transitively.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Turn on auto-fix | Re-trigger cubic

@Miyamura80
Miyamura80 merged commit 30aaf29 into main Nov 11, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants