Repository navigation
🐛 Bump Electron to 43.8.7 for the Chromium 157 security batch - #135
Conversation
Bump the uv version staged into the Windows desktop installer (resources/runtimes/uv) from 0.11.21 to 0.13.4. uv 0.13.4 ships webpki-root-certs 1.0.10, which drops the compromised eMudhra root. The script already verifies each zip against the release's .sha256 file; both 0.13.4 Windows assets were downloaded and checked. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
webpki-roots 1.0.10 drops emSign ECC Root CA - G3 from the bundled trust store after the eMudhra intermediate key compromise. stdiod 1.0.7 -> 1.0.10 (the 0.26.11 shim depends on ^1 and now resolves to 1.0.10), detectord 1.0.8 -> 1.0.10. Lockfile-only change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
Electron 43.8.1 applies the certificate SPKI blocklist to Node and adds the 8 compromised emSign intermediate keys; 43.8.3 is the latest 43-x-y patch (adds a 64-change Chromium/V8 security cherry-pick). Range raised to ^43.8.3 so installs cannot resolve below the patched build (43.2.0 -> 43.8.3). npm also resynced the stale desktop workspace version in package-lock.json (0.6.9 -> 0.6.14, matching package.json). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
electron-builder packages the runtime pinned by electronVersion, not the resolved electron devDependency, so installers were still shipping 40.8.0 (EOL, no eMudhra fix) while dev and e2e already ran on 43.x. Pin the packaged runtime to 43.8.3, matching the devDependency. The desktop app has no runtime native modules, so no ABI rebuild is involved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
0.103.16 rejects certificate paths containing the compromised emSign intermediates; cargo-deny flags earlier versions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
Every GitHub Actions `uses:` is now pinned to a 40-character commit sha with the human-readable tag kept as a comment. Each sha was resolved from the tag and independently verified, so a moved or rewritten tag can no longer swap in different code. - dtolnay/rust-toolchain is pinned to a master commit, which no longer carries the channel in the ref, so every step now passes `toolchain: stable` explicitly. - actions/setup-node v6 steps move to v6.5.0 alongside the v7 pins. - scripts/check_immutable_refs.py fails if any Dockerfile or workflow uses a mutable image tag or action ref; it runs in the new "Pinned refs" workflow on every pull request and push to main, and locally via `npm run pinned-refs:check`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
The guard now clears a pin-exempt at a blank line, joins continuation lines like Docker (honouring a `# escape=` directive), requires a bare or docker:// runs.image to be pinned, reads flow-style and spaced YAML keys, checks every ref on a line and requires owner/repo@<sha>. On pull requests the workflow runs the base branch's copy of the checker. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
cargo-deny fails on tokio 1.52.1 (AsyncFd constructors violate I/O safety); 1.53.3 is the patched release on this line. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
FROM now resolves only global ARGs (declared before the first FROM), and each stage starts empty, seeing a global value only by redeclaring it without a default, so a pinned stage-level ARG can no longer mask a mutable global default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`ARG NAME=` now sets the value to "" instead of leaving an earlier default in place, so the empty value fails closed as untagged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
Continuation lines of an open `{ ... }` / `[ ... ]` keep flow-style
parsing, so `uses:` after another key on such a line is checked, and a
`*version:` whose value `latest` starts on the next line is flagged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
A `*version:` key inside a flow collection whose value starts on the next line is now checked too, and comment lines before the value are skipped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
…blowup
- An anchor or tag before a block key (`- &step uses: x`, `- !!str uses: x`,
`{ &k uses: x }`) no longer hides the key from the check.
- Verbatim tags with commas (`!<tag:yaml.org,2002:seq> [...]`) now open a
flow collection.
- Each node property must end at whitespace or a bracket, so a run like
`&&&&x` has one split instead of exponentially many (the old pattern hung
on 30 characters).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`!<[^>]*>` ran to the end of the line from every comma when the tag was never closed, so a flow line of repeated `,!<` was quadratic (32k repeats took 8s). YAML verbatim tags hold URI characters only, so the tag now stops at whitespace or another `<`; the same line takes 0.04s. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`bun-version: &v latest` (and `&v` with `latest` on the next line) slipped past the `latest` check because the value was taken to be `&v`, and `uses: &pin owner/repo@<sha>` was wrongly rejected for the same reason. Node properties after the colon are now skipped before the value is read, on the key's own line and on the line below it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
`container: &c` followed by `{ image: <pinned> }` on the next line was
read as a scalar image and rejected. A continuation that opens a `{` or
`[` collection is now left to the per-line flow scanner, which already
checks the keys inside it, so a mutable image there is still flagged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
… claude/festive-cori-e6o9o8
Bump electron ^43.8.3 -> ^43.8.6 (lockfile regenerated with npm); 43.8.4 updated the bundled Node.js to v24.22.1, which fixes the Brotli decoder out-of-bounds write. Bump CI bun-version 1.4.3 -> 1.4.4. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
The desktop SAML/SSO window (ipc/ipcHandlers.ts) renders third-party IdP pages, the one surface where renderer bugs from the Chromium 157 batch (sandbox escape, V8 type confusion) are reachable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wtx3dU8PQvgyubf6ZpNaG3
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
There was a problem hiding this comment.
2 issues found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/desktop/package.json">
<violation number="1" location="packages/desktop/package.json:65">
P1: The package bump does not update the runtime shipped in installers: `electron-builder` is pinned to `electronVersion: 43.8.3` in `packages/desktop/electron-builder.yml`, so packaged releases will continue to omit the 43.8.7 security fixes. Update that builder pin to 43.8.7 alongside this dependency change.</violation>
<violation number="2" location="packages/desktop/package.json:65">
P1: `electron@43.8.7` is not a Chromium 157 build: its release notes report Chromium 150.0.7871.250 and no Chromium 157 security batch. Select a release whose Chromium version contains the intended fixes, then regenerate the lockfile.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| "@vitejs/plugin-react": "^4.5.2", | ||
| "cross-env": "^10.1.0", | ||
| "electron": "^43.8.6", | ||
| "electron": "^43.8.7", |
There was a problem hiding this comment.
P1: The package bump does not update the runtime shipped in installers: electron-builder is pinned to electronVersion: 43.8.3 in packages/desktop/electron-builder.yml, so packaged releases will continue to omit the 43.8.7 security fixes. Update that builder pin to 43.8.7 alongside this dependency change.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/desktop/package.json, line 65:
<comment>The package bump does not update the runtime shipped in installers: `electron-builder` is pinned to `electronVersion: 43.8.3` in `packages/desktop/electron-builder.yml`, so packaged releases will continue to omit the 43.8.7 security fixes. Update that builder pin to 43.8.7 alongside this dependency change.</comment>
<file context>
@@ -62,7 +62,7 @@
"@vitejs/plugin-react": "^4.5.2",
"cross-env": "^10.1.0",
- "electron": "^43.8.6",
+ "electron": "^43.8.7",
"electron-builder": "^26.16.1",
"electron-vite": "^5.0.0",
</file context>
| "@vitejs/plugin-react": "^4.5.2", | ||
| "cross-env": "^10.1.0", | ||
| "electron": "^43.8.6", | ||
| "electron": "^43.8.7", |
There was a problem hiding this comment.
P1: electron@43.8.7 is not a Chromium 157 build: its release notes report Chromium 150.0.7871.250 and no Chromium 157 security batch. Select a release whose Chromium version contains the intended fixes, then regenerate the lockfile.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/desktop/package.json, line 65:
<comment>`electron@43.8.7` is not a Chromium 157 build: its release notes report Chromium 150.0.7871.250 and no Chromium 157 security batch. Select a release whose Chromium version contains the intended fixes, then regenerate the lockfile.</comment>
<file context>
@@ -62,7 +62,7 @@
"@vitejs/plugin-react": "^4.5.2",
"cross-env": "^10.1.0",
- "electron": "^43.8.6",
+ "electron": "^43.8.7",
"electron-builder": "^26.16.1",
"electron-vite": "^5.0.0",
</file context>
Summary
electronfrom 43.8.6 to 43.8.7 inpackages/desktopand the lockfile.packages/desktop/src/main/ipc/ipcHandlers.ts:87,authWindow.loadURL(samlUrl)), which loads third-party identity provider (IdP) pages.Caveat
I couldn't confirm that 43.8.7's release notes include the Chromium 157 backports: releases.electronjs.org and the electron GitHub releases page are blocked from the sandbox. If they don't, follow up with a move to 45.x.
Testing
tsctypecheck (node + web): passvitest runin packages/desktop: 22 files, 210 tests passpinned-refs:checkandversion:check: passGenerated by Claude Code
Summary by cubic
Bumps
electronfrom 43.8.6 to 43.8.7 inpackages/desktopand the lockfile to pick up the Chromium 157 security batch (~170 fixes), including a sandbox escape and V8 type confusion. The affected renderer bugs are reachable only through the SAML/SSO window, which loads third-party identity provider pages.I couldn't confirm that 43.8.7's release notes include the Chromium 157 backports, so verify that or follow up with a move to 45.x. Typecheck, the desktop
vitestsuite (210 tests),pinned-refs:check, andversion:checkall pass.Written for commit 9cf50a9. Summary will update on new commits.