Repository navigation
fix(2.11): playFile prepends the language path, fix volume example - #37
Merged
Merged
Conversation
A relative filename gets the current language's sound directory put in front of it, so the language is prepended, not appended. The first example passes volume 5 but its comment said 2. Supersedes #10. Co-Authored-By: Alex K <arkarkark@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
📖 Docs preview: https://pr-37-edgetx-lua-reference-guide.edgetx.workers.dev/2.11/ Built from 2e5196c as the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports @arkarkark's fix from #10 to the MkDocs 2.11 docs (
api-reference/audio-sound/playfile.md):playFile("armed.wav", 5)example comment said "use Wav volume 2". It now says 5.The same fix is in #36 for 2.12, and in EdgeTX/edgetx#7936 for the firmware luadoc the 2.12+ pages are generated from. 2.4–2.10 are left as they are.
mkdocs buildpasses with no warnings.Supersedes #10, credited as co-author.
🤖 Generated with Claude Code