Full test run isolates the judge for every suite - #530
Open
EdbertChan wants to merge 1 commit into
Open
Conversation
run_all_tests.sh exports a temporary judge state folder and a local stub runner for every suite, so a test that skips the shared base still cannot reach a model or the user's judge queue. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013smxPCr4XeE7R77zVtN1u4 Change-Id: I8429f17d7c0c75cb8b2217e81e689a6c501206f9
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_98767b7c-a014-481e-9fa9-9ec9cbbaa71b) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One script runs every test in the repo.
A test that skips the shared setup could still reach a model during that run.
The script now points the judge at a temporary folder and a local stand-in for the whole run.
Review Claim
The full test run gives the judge a throwaway folder and a stand-in runner.
Review Lane
behavior
Review Unit
engine-runtime
Safety Invariant
Only the test runner script changes. It sets two variables and deletes the temporary folder on exit. A probe under those variables printed a temp folder, the stub runner, and a no answer.
Slice Rationale
Runner-level isolation is a separate path from the shared base, so it gets its own slice.
Stack position 6 of 7, split from one bundled change. Merge bottom-up.
Non-goals
Test Plan
Test Plan
judge.state_root()—/var/folders/.../catstack-llm-judge-tests-31egi4q4;[n for n,_ in judge.runners()]—['stub'];judge.ask('x')['answer']—{'match': False}bash scripts/run_all_tests.shon the stack tip —run_all_tests exit=0, 53 suitesOK, 1970 tests (one skipped)python3 engine/skills/make-pr/scripts/preflight.py --base <stack parent>—ok preflight passedRevert Plan
Revert Plan
git revert <merge-commit-sha>🤖 Generated with Claude Code
https://claude.ai/code/session_013smxPCr4XeE7R77zVtN1u4
Note
Low Risk
Only the aggregate test shell script changes; it hardens test isolation without touching judge logic, auth, or production paths.
Overview
Full-repo test runs now isolate the LLM judge so suites cannot hit real model runners or share persistent judge state.
At startup,
scripts/run_all_tests.shcreates a throwawayCATSTACK_LLM_JUDGE_STATE_DIR, registers an EXIT trap to remove it, and setsCATSTACK_LLM_JUDGE_RUNNERSto a single local stub that always prints{"match": false}. Those exports apply for the entire discover loop; which suites run and CI are unchanged.Reviewed by Cursor Bugbot for commit d6c5cfb. Bugbot is set up for automated code reviews on this repo. Configure here.