PR summaries: 150-word limit, checked on GitHub, required to merge - #524
Merged
Conversation
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_305bee43-03ed-469e-9792-53a8863ef6a4) |
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
The summary checker now fails a Summary over 150 words and tells the writer how many words to cut. The draft-pr skill says to write the Summary with the diu skill. A new CI workflow runs the same checker on each PR's live body, including edits made on GitHub, because PR #518 was published with a summary the local checker already rejected. The merge queue now requires that check to pass, next to lint and test. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014uqkMWYjsKGenUSA1CqBVv Change-Id: Ie7e51550f991022ed4a5f5a40e07613f5ee6b75e
EdbertChan
force-pushed
the
stack/EdbertChan/EdbertChan/pr-summary-150-words/draft-pr-cap-pr-summary-150-words-check-pr-text-ci--e7e51550
branch
from
September 13, 2026 03:52
b8daef1 to
f83499e
Compare
Owner
Author
Revision history
|
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_53be56a5-d7c9-4b9c-a50b-dbef8c586a31) |
Owner
Author
|
@Mergifyio queue |
Contributor
Merge Queue Status
This pull request spent 5 minutes 50 seconds in the queue, including 5 minutes 6 seconds running CI. Required conditions to merge
|
5 tasks
mergify
Bot
deleted the
stack/EdbertChan/EdbertChan/pr-summary-150-words/draft-pr-cap-pr-summary-150-words-check-pr-text-ci--e7e51550
branch
September 13, 2026 04:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A checker reads every PR write-up before it goes out. It makes sure a busy reader can follow the short summary at the top.
It had no length limit. A summary could run on and still pass.
It also only ran when Claude wrote the PR by hand. Other write-ups skipped it. One recent PR went out long and full of file names.
Now a summary over 150 words fails, and the message says how many words to cut. The writing guide says to use plain, short words.
A new check on GitHub runs on every PR, even after edits on the website. A PR that fails it cannot merge.
Review Claim
Approve a 150-word limit on the PR summary, and a GitHub check that runs the same PR checker on every PR and must pass before merging.
Review Lane
behavior
Review Unit
engine-runtime
Safety Invariant
The merge queue now needs the new check to pass, next to lint and test; nothing else in the queue rules changes. The limit counts words in the Summary section only; later sections stay unlimited. A missing Summary is reported as "unchecked", never as clean.
Slice Rationale
The word limit, the guide text, and the GitHub check are one rule: the guide states it, the checker enforces it, and CI makes sure the checker actually runs. Without the CI piece, the limit only applies to PRs written through the local skill, which is the gap that let PR #518 out.
Non-goals
Test Plan
Test Plan
Fail-before: new tests added, checker unchanged.
Pass-after, whole draft-pr suite:
Preflight:
Impact scan:
validate-pr-body.mjsrun on every open PR's live body with its changed files. 12 pass, 17 fail, 0 unchecked. No PR fails on the new word limit; every failure is an existing rule (code names, reading grade, missing sections, bad review unit).python3 -m unittest test_draft_pr_scripts(engine/skills/draft-pr/tests)python3 engine/skills/make-pr/scripts/preflight.py --base origin/main.mergify.ymlparses; merge conditions read back as['check-success = lint', 'check-success = test', 'check-success = validate']PR bodyworkflow on this PR's real runs, both ways:Revert Plan
Revert Plan
git revert <sha>🤖 Generated with Claude Code
https://claude.ai/code/session_014uqkMWYjsKGenUSA1CqBVv