Skip to content

PR summaries: 150-word limit, checked on GitHub, required to merge - #524

Merged
mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/EdbertChan/pr-summary-150-words/draft-pr-cap-pr-summary-150-words-check-pr-text-ci--e7e51550
Sep 13, 2026
Merged

PR summaries: 150-word limit, checked on GitHub, required to merge#524
mergify[bot] merged 1 commit into
mainfrom
stack/EdbertChan/EdbertChan/pr-summary-150-words/draft-pr-cap-pr-summary-150-words-check-pr-text-ci--e7e51550

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Sep 13, 2026

Copy link
Copy Markdown
Owner

Summary

A checker reads every PR write-up before it goes out. It makes sure a busy reader can follow the short summary at the top.

It had no length limit. A summary could run on and still pass.

It also only ran when Claude wrote the PR by hand. Other write-ups skipped it. One recent PR went out long and full of file names.

Now a summary over 150 words fails, and the message says how many words to cut. The writing guide says to use plain, short words.

A new check on GitHub runs on every PR, even after edits on the website. A PR that fails it cannot merge.

Review Claim

Approve a 150-word limit on the PR summary, and a GitHub check that runs the same PR checker on every PR and must pass before merging.

Review Lane

behavior

Review Unit

engine-runtime

Safety Invariant

The merge queue now needs the new check to pass, next to lint and test; nothing else in the queue rules changes. The limit counts words in the Summary section only; later sections stay unlimited. A missing Summary is reported as "unchecked", never as clean.

Slice Rationale

The word limit, the guide text, and the GitHub check are one rule: the guide states it, the checker enforces it, and CI makes sure the checker actually runs. Without the CI piece, the limit only applies to PRs written through the local skill, which is the gap that let PR #518 out.

Non-goals

  • Does not rewrite the 17 open PRs whose bodies already fail the existing rules (scan below). Each one now needs its body fixed before it can merge.
  • Does not change Invoker's own copy of the PR skill.

Test Plan

Test Plan

Fail-before: new tests added, checker unchanged.

FAIL: test_summary_over_150_words_fails_and_says_how_many_to_cut
AssertionError: 0 != 1 : PR body validation passed.
Ran 3 tests in 2.804s
FAILED (failures=1)
exit=1

Pass-after, whole draft-pr suite:

Ran 16 tests in 32.059s
OK
exit=0

Preflight:

declare Review Unit: engine-runtime
ok      preflight passed
preflight exit=0

Impact scan: validate-pr-body.mjs run on every open PR's live body with its changed files. 12 pass, 17 fail, 0 unchecked. No PR fails on the new word limit; every failure is an existing rule (code names, reading grade, missing sections, bad review unit).

  • python3 -m unittest test_draft_pr_scripts (engine/skills/draft-pr/tests)
  • python3 engine/skills/make-pr/scripts/preflight.py --base origin/main
  • .mergify.yml parses; merge conditions read back as ['check-success = lint', 'check-success = test', 'check-success = validate']
  • The PR body workflow on this PR's real runs, both ways:
run 34736161445 (PR opened, body = commit message only)
PR body validation failed:
- Missing required section: ## Summary
##[error]Process completed with exit code 1.

run 34736169352 (after the body edit)
PR body validation passed.

Revert Plan

Revert Plan
  • Safe to revert? Yes
  • Revert command: git revert <sha>
  • Post-revert steps: None. The GitHub check and its merge requirement disappear, and summaries of any length pass again.
  • Data migration? No

🤖 Generated with Claude Code

https://claude.ai/code/session_014uqkMWYjsKGenUSA1CqBVv

@cursor

cursor Bot commented Sep 13, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_305bee43-03ed-469e-9792-53a8863ef6a4)

@EdbertChan EdbertChan changed the title draft-pr: cap the PR summary at 150 words and check PR text in CI PR summaries: 150-word limit, checked on GitHub for every PR Sep 13, 2026
@mergify

mergify Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Queued — the merge queue status continues in this comment ↓.

The summary checker now fails a Summary over 150 words and tells the
writer how many words to cut. The draft-pr skill says to write the
Summary with the diu skill. A new CI workflow runs the same checker on
each PR's live body, including edits made on GitHub, because PR #518
was published with a summary the local checker already rejected. The
merge queue now requires that check to pass, next to lint and test.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014uqkMWYjsKGenUSA1CqBVv
Change-Id: Ie7e51550f991022ed4a5f5a40e07613f5ee6b75e
@EdbertChan EdbertChan changed the title PR summaries: 150-word limit, checked on GitHub for every PR draft-pr: cap the PR summary at 150 words and check PR text in CI Sep 13, 2026
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/EdbertChan/pr-summary-150-words/draft-pr-cap-pr-summary-150-words-check-pr-text-ci--e7e51550 branch from b8daef1 to f83499e Compare September 13, 2026 03:52
@EdbertChan

Copy link
Copy Markdown
Owner Author

Revision history

# Type Changes Reason Date
1 initial b8daef1 2026-09-13 03:52 UTC
2 content b8daef1 → f83499e (raw) 2026-09-13 03:52 UTC

@cursor

cursor Bot commented Sep 13, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_53be56a5-d7c9-4b9c-a50b-dbef8c586a31)

@EdbertChan EdbertChan changed the title draft-pr: cap the PR summary at 150 words and check PR text in CI PR summaries: 150-word limit, checked on GitHub, required to merge Sep 13, 2026
@EdbertChan

Copy link
Copy Markdown
Owner Author

@Mergifyio queue

@mergify

mergify Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 5 minutes 50 seconds in the queue, including 5 minutes 6 seconds running CI.

Required conditions to merge
  • check-success = lint
  • check-success = test

@mergify mergify Bot added the queued label Sep 13, 2026
@mergify
mergify Bot merged commit 1343d95 into main Sep 13, 2026
8 of 13 checks passed
@mergify
mergify Bot deleted the stack/EdbertChan/EdbertChan/pr-summary-150-words/draft-pr-cap-pr-summary-150-words-check-pr-text-ci--e7e51550 branch September 13, 2026 04:04
@mergify mergify Bot removed the queued label Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant