merge queue: checking #514 on main (af3626d)

.github/workflows/ci.yml

@@ -31,6 +31,9 @@ jobs:
       - name: hook e2e coverage gate (positive + negative test per detector)
         run: python3 scripts/check_hook_test_coverage.py
 
+      - name: silent hook exception gate
+        run: python3 scripts/check_no_silent_hook_except.py
+
       - name: rule wiring gate (every phrase checker has a caller or a stated reason)
         run: python3 scripts/check_rules_are_wired.py
 

engine/hooks/answer-overrides-menu/claude_posttooluse.py

@@ -21,7 +21,8 @@ def main() -> None:
         return
     try:
         text = decide(payload)
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error answer-overrides-menu: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if not text:
         return

engine/hooks/auto-pr/claude_stop_autopr.py

@@ -30,7 +30,8 @@ def main() -> None:
             deliver=False,
             debounce=True,
         )
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error auto-pr: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if not message:
         return

engine/hooks/auto-pr/cursor_session.py

@@ -24,7 +24,8 @@ def main() -> None:
             payload if isinstance(payload, dict) else {},
             argv=sys.argv[1:],
         )
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error auto-pr: {type(exc).__name__}: {exc}", file=sys.stderr)
         print(json.dumps({"followup_message": ""}))
         return
     print(json.dumps({"followup_message": message or ""}))

engine/hooks/bug-complaint-leak/claude_posttooluse.py

@@ -96,7 +96,8 @@ def main() -> None:
         return
     try:
         process(payload)
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error bug-complaint-leak: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
 
 

engine/hooks/bug-complaint-leak/claude_pretooluse_grep.py

@@ -72,7 +72,8 @@ def main() -> None:
             from state import save_state
 
             save_state(payload, state)
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error bug-complaint-leak: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
 
 

engine/hooks/bug-complaint-leak/claude_prompt_submit.py

@@ -34,7 +34,8 @@ def main() -> None:
                 }
             )
         )
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error bug-complaint-leak: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
 
 

engine/hooks/bug-complaint-leak/cursor_before_submit.py

@@ -26,7 +26,8 @@ def main() -> None:
             quotes = extract_quoted_symptoms(prompt)
             remember_bug_complaint(payload, prompt, quotes, checklist)
         print(json.dumps({"continue": True}))
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error bug-complaint-leak: {type(exc).__name__}: {exc}", file=sys.stderr)
         print(json.dumps({"continue": True}))
 
 

engine/hooks/bug-complaint-leak/cursor_post_tool_use.py

@@ -26,7 +26,8 @@ def main() -> None:
         state["cursor_checklist_pending"] = False
         save_state(payload, state)
         print(json.dumps({"additional_context": checklist}))
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error bug-complaint-leak: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
 
 

engine/hooks/build-the-lever/claude_posttooluse.py

@@ -30,7 +30,8 @@ def main() -> None:
                 }
             )
         )
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error build-the-lever: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
 
 

engine/hooks/build-the-lever/claude_prompt_submit.py

@@ -30,7 +30,8 @@ def main() -> None:
                 }
             )
         )
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error build-the-lever: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
 
 

engine/hooks/build-the-lever/codex_posttooluse.py

@@ -30,7 +30,8 @@ def main() -> None:
                 }
             )
         )
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error build-the-lever: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
 
 

engine/hooks/build-the-lever/codex_prompt_submit.py

@@ -30,7 +30,8 @@ def main() -> None:
                 }
             )
         )
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error build-the-lever: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
 
 

engine/hooks/build-the-lever/cursor_before_submit.py

@@ -21,7 +21,8 @@ def main() -> None:
         if is_bulk_work(extract_prompt_text(payload if isinstance(payload, dict) else {})):
             remember_bulk_prompt(payload)
         print(json.dumps({"continue": True}))
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error build-the-lever: {type(exc).__name__}: {exc}", file=sys.stderr)
         print(json.dumps({"continue": True}))
 
 

engine/hooks/build-the-lever/cursor_post_tool_use.py

@@ -25,7 +25,8 @@ def main() -> None:
         record_file_mutation(payload if isinstance(payload, dict) else {})
         if consume_prompt_pending(payload) or should_inject_for_edits(payload):
             print(json.dumps({"additional_context": reminder_text()}))
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error build-the-lever: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
 
 

engine/hooks/cat-mode-default/claude_pretooluse_agent.py

@@ -24,7 +24,8 @@ def main() -> None:
         return
     try:
         updated = agent_updated_input(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error cat-mode-default: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if updated is None:
         return

engine/hooks/cat-mode-default/claude_prompt_submit.py

@@ -19,7 +19,8 @@ def main() -> None:
         return
     try:
         context = decide(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error cat-mode-default: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if context is None:
         return

engine/hooks/categorical-scope-guard/detect.py

@@ -12,6 +12,7 @@
 mutation by status but the filter values or the human turns could not be read.
 """
 from __future__ import annotations
+import sys
 
 import json
 import os
@@ -830,6 +831,7 @@ def decide(command: str, window_loader) -> Verdict:
     try:
         found = scoped_mutation_filters(command)
     except Exception as exc:
+        print(f"catstack-hook-error categorical-scope-guard: {type(exc).__name__}: {exc}", file=sys.stderr)
         return Verdict(UNCHECKED, (
             f"categorical-scope-guard: UNCHECKED -- the command parser failed ({exc!r}) on a command that "
             "mentions a status or state. Blocked rather than passed; drop the status filter or rephrase the command."

engine/hooks/external-claim-gate/claude_pretooluse.py

@@ -42,6 +42,7 @@ def main() -> None:
     try:
         findings = evaluate(command, cwd)
     except Exception as exc:
+        print(f"catstack-hook-error external-claim-gate: {type(exc).__name__}: {exc}", file=sys.stderr)
         _refuse_if_destination(command, f"the detector failed ({exc!r})")
         return
     if findings:

engine/hooks/frustration-watchdog/claude_stop_check.py

@@ -217,7 +217,8 @@ def main():
     try:
         msgs = human_user_messages(transcript_path)
         kinds = impatience_kinds(msgs)
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error frustration-watchdog: {type(exc).__name__}: {exc}", file=sys.stderr)
         return  # fail open: a broken watchdog must never brick a session
     if not kinds:
         return
@@ -227,6 +228,7 @@ def main():
         refused = turn_has_hook_refusal(transcript_path)
         unchecked = None
     except Exception as e:
+        print(f"catstack-hook-error frustration-watchdog: {type(e).__name__}: {e}", file=sys.stderr)
         refused = False
         unchecked = f"{type(e).__name__}: {e}"
     head = (

engine/hooks/frustration-watchdog/tests/test_hooks.py

@@ -318,7 +318,8 @@ def test_unreadable_tool_results_use_default_wording_and_say_so(self):
         with patch.object(claude_stop_check, "turn_has_hook_refusal", side_effect=OSError("disk gone")):
             blocked, err = self.run_lines([human(WAITING)] + tool_turn(HOOK_REFUSAL_TEXT))
         self.assertTrue(blocked)
-        self.assertTrue(err.startswith(DEFAULT_WAITING_FEEDBACK))
+        self.assertTrue(err.startswith("catstack-hook-error frustration-watchdog: OSError: disk gone\n"))
+        self.assertIn(DEFAULT_WAITING_FEEDBACK, err)
         self.assertIn("could not read this turn's tool results (OSError: disk gone)", err)
 
 

engine/hooks/hook-freshness/claude_prompt_submit.py

@@ -18,7 +18,8 @@ def main() -> None:
         return
     try:
         out = decide_json(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error hook-freshness: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if out:
         print(out)

engine/hooks/llm-judge/judge.py

@@ -218,6 +218,7 @@ def run_job(path: str) -> dict:
         job.setdefault("id", stem)
         result = verdict(job, ask(str(job["prompt"])))
     except Exception as exc:
+        print(f"catstack-hook-error llm-judge: {type(exc).__name__}: {exc}", file=sys.stderr)
         log(f"job {job.get('id')} failed: {type(exc).__name__}: {exc}\n{traceback.format_exc()}")
         result = verdict(job, {"outcome": "unchecked", "attempts": []})
         result["reason"] = clip(f"judge error {type(exc).__name__}", str(exc))

engine/hooks/named-verb-guard/claude_stop_check.py

@@ -20,7 +20,8 @@ def main() -> None:
         return
     try:
         message = decide(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error named-verb-guard: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if not message:
         return

engine/hooks/narrow-the-scope/claude_posttooluse.py

@@ -17,7 +17,8 @@ def main() -> None:
         return
     try:
         text = observe(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error narrow-the-scope: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if not text:
         return

engine/hooks/no-comments/claude_pretooluse.py

@@ -17,7 +17,8 @@ def main() -> None:
         return
     try:
         message = decide(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error no-comments: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if not message:
         return

engine/hooks/playbook-router/claude_prompt_submit.py

@@ -14,7 +14,8 @@ def main() -> None:
         return
     try:
         context = decide(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error playbook-router: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if context is None:
         return

engine/hooks/prove-it-ship-gate/claude_stop_check.py

@@ -20,7 +20,8 @@ def main() -> None:
         return
     try:
         message = decide(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error prove-it-ship-gate: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if not message:
         return

engine/hooks/reflect-on-thrash/claude_stop_reflect.py

@@ -23,7 +23,8 @@ def main() -> None:
         message = decide(
             payload if isinstance(payload, dict) else {},
         )
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error reflect-on-thrash: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if message:
         sys.stderr.write(message + "\n")

engine/hooks/reflect-on-thrash/cursor_session.py

@@ -26,7 +26,8 @@ def main() -> None:
             payload if isinstance(payload, dict) else {},
             argv=sys.argv[1:],
         )
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error reflect-on-thrash: {type(exc).__name__}: {exc}", file=sys.stderr)
         print(json.dumps({"followup_message": ""}))
         return
     print(json.dumps({"followup_message": message or ""}))

engine/hooks/reflect-on-thrash/detect.py

@@ -144,7 +144,8 @@ def thrash_hits(path: str) -> list[str]:
                 result = token_audit.audit_codex(path)
             return _hits_from_flags(list(result.get("flags") or []))
         return _cursor_duplicate_hits(path)
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error reflect-on-thrash: {type(exc).__name__}: {exc}", file=sys.stderr)
         return []
 
 

engine/hooks/repeat-error-stop/claude_posttooluse.py

@@ -16,7 +16,8 @@ def main() -> None:
     try:
         payload = json.load(sys.stdin)
         kind, reason = record_result(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error repeat-error-stop: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if kind == "block":
         print(json.dumps({

engine/hooks/repeat-error-stop/claude_pretooluse.py

@@ -12,7 +12,8 @@ def main() -> None:
     try:
         payload = json.load(sys.stdin)
         blocked, reason = tool_block_reason(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error repeat-error-stop: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if blocked:
         sys.stderr.write(reason + "\n")

engine/hooks/repeat-error-stop/claude_prompt_reset.py

@@ -12,7 +12,8 @@ def main() -> None:
     try:
         payload = json.load(sys.stdin)
         handle_prompt(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error repeat-error-stop: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
 
 

engine/hooks/repeat-error-stop/codex_posttooluse.py

@@ -12,7 +12,8 @@ def main() -> None:
     try:
         payload = json.load(sys.stdin)
         kind, reason = record_result(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error repeat-error-stop: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if kind == "block":
         print(json.dumps({

engine/hooks/repeat-error-stop/codex_pretooluse.py

@@ -12,7 +12,8 @@ def main() -> None:
     try:
         payload = json.load(sys.stdin)
         blocked, reason = tool_block_reason(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error repeat-error-stop: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if blocked:
         print(json.dumps({

engine/hooks/repeat-error-stop/codex_prompt_reset.py

@@ -12,7 +12,8 @@ def main() -> None:
     try:
         payload = json.load(sys.stdin)
         handle_prompt(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error repeat-error-stop: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
 
 

engine/hooks/repeat-error-stop/cursor_before_submit.py

@@ -12,7 +12,8 @@ def main() -> None:
     try:
         payload = json.load(sys.stdin)
         handle_prompt(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error repeat-error-stop: {type(exc).__name__}: {exc}", file=sys.stderr)
         pass
     print(json.dumps({"continue": True}))
 

engine/hooks/repeat-error-stop/cursor_post_tool_use.py

@@ -12,7 +12,8 @@ def main() -> None:
     try:
         payload = json.load(sys.stdin)
         kind, reason = record_result(payload if isinstance(payload, dict) else {})
-    except Exception:
+    except Exception as exc:
+        print(f"catstack-hook-error repeat-error-stop: {type(exc).__name__}: {exc}", file=sys.stderr)
         return
     if kind in ("block", "nudge"):
         print(json.dumps({"additional_context": reason}))