Skip to content

README: name the reflect enforcement setting and its four hooks - #501

Open
EdbertChan wants to merge 1 commit into
stack/EdbertChan/docs/reflect-enforcement-flag-readme/reflect-automate-me-enforcement-opt-behind-one--82a63478from
stack/EdbertChan/docs/reflect-enforcement-flag-readme/readme-names-reflect-enforcement-flag-four-hooks--d9143a48
Open

README: name the reflect enforcement setting and its four hooks#501
EdbertChan wants to merge 1 commit into
stack/EdbertChan/docs/reflect-enforcement-flag-readme/reflect-automate-me-enforcement-opt-behind-one--82a63478from
stack/EdbertChan/docs/reflect-enforcement-flag-readme/readme-names-reflect-enforcement-flag-four-hooks--d9143a48

Conversation

@EdbertChan

@EdbertChan EdbertChan commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Summary

This kit has a front page that lists its checkers. People read it to learn what each checker does and how to set it up.

The problem: four checkers that push you to review your work became opt-in, but the front page did not say so.

The cause: the change that added the switch was kept to code and tests. The front page is a separate kind of file.

The fix: the front page now names the switch, lists the four checkers it controls, and shows the one line that turns them on.

Review Claim

The front page tells a reader that four review-pushing checkers are off until one setting turns them on, and how to set it.

Review Lane

docs

Review Unit

docs

Safety Invariant

Documentation only: one table row gains a note and one new section is added to README.md. No code, test, or install behavior changes.

Slice Rationale

Stacked on the PR that adds CATSTACK_REFLECT_ENFORCEMENT, because the lane rules keep root docs out of a behavior PR. It describes that PR's behavior, so it merges after it.

The first draft carried this README change inside #500. The validator refused it:

$ node scripts/validate-pr-body-local.mjs --body-file pr-body.md --base origin/main
PR body validation failed:
- Review lane behavior cannot ship with docs files in the same PR. Split behavior work from those files into their own slice.
- PR body Review Unit "engine-runtime" cannot ship with docs files in the same PR. Split this into one Review Unit per PR.

Non-goals

  • Does not change any hook, test, or install step.
  • Does not add rows for hooks the README table did not already list, beyond the new opt-in section.

Test Plan

Test Plan
  • bash scripts/run_all_tests.sh on this branch's exact tree: EXIT=0, 1932 ok, 0 failed, 1 skipped (CONSUMER_REPO_ROOT not set; unrelated)
  • git diff --stat <tested-head> HEAD is empty: this branch is the tree the full suite ran on

Revert Plan

Revert Plan
  • Safe to revert? Yes
  • Revert command: git revert <merge-sha>
  • Post-revert steps: None
  • Data migration? No

🤖 Generated with Claude Code

https://claude.ai/code/session_011vy9sMw49j6PqS2NLRBYhs


Note

Low Risk
README-only documentation; no runtime, install, or hook behavior changes.

Overview
Documents the opt-in reflect enforcement switch on the main hooks page so readers know four /reflect-pushing checkers stay off until they enable it.

The reflect-on-thrash row now notes it is inactive unless CATSTACK_REFLECT_ENFORCEMENT=1, with a pointer to the new section below.

A new Reflect enforcement (opt-in) subsection lists scope-lock, reflect-on-thrash, wrong-check-reflect, and verdict-flip-watch, shows the ~/.catstack.env one-liner to turn them on, explains env file precedence, and clarifies that frustration-watchdog is outside this group—with a link to engine/hooks/_flags/README.md.

Reviewed by Cursor Bugbot for commit 24f54ea. Bugbot is set up for automated code reviews on this repo. Configure here.

@EdbertChan

EdbertChan commented Sep 12, 2026

Copy link
Copy Markdown
Owner Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 Reflect and automate-me hooks are off until one setting turns them on #500
2 README: name the reflect enforcement setting and its four hooks #501 👈

@cursor

cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_240fdc7e-5508-41a6-a97e-d27365d541f6)

@EdbertChan EdbertChan changed the title docs: README names the reflect enforcement flag and its four hooks README: name the reflect enforcement setting and its four hooks Sep 12, 2026
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011vy9sMw49j6PqS2NLRBYhs
Change-Id: Id9143a48f8bdc165254f60e9f6016f62acde2049
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/docs/reflect-enforcement-flag-readme/readme-names-reflect-enforcement-flag-four-hooks--d9143a48 branch from c48f2c0 to 24f54ea Compare September 12, 2026 19:28
@EdbertChan
EdbertChan force-pushed the stack/EdbertChan/docs/reflect-enforcement-flag-readme/reflect-automate-me-enforcement-opt-behind-one--82a63478 branch from 0c00aa6 to 710df82 Compare September 12, 2026 19:28
@EdbertChan EdbertChan changed the title README: name the reflect enforcement setting and its four hooks docs: README names the reflect enforcement flag and its four hooks Sep 12, 2026
@cursor

cursor Bot commented Sep 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_88765792-d043-4680-b3ec-c68b45a4b8ee)

@EdbertChan

Copy link
Copy Markdown
Owner Author

Revision history

# Type Changes Reason Date
1 initial c48f2c0 2026-09-12 19:28 UTC
2 rebase c48f2c0 → 24f54ea (rebase only) 2026-09-12 19:28 UTC

@EdbertChan EdbertChan changed the title docs: README names the reflect enforcement flag and its four hooks README: name the reflect enforcement setting and its four hooks Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant