Add playwright to hugo-node#57
Draft
oliviergoulet5 wants to merge 1 commit into
Draft
Conversation
Member
Author
|
...and I'm noticing the versions aren't lining up. I'll tag an older version of Playwright that supports Node 18 for the default arg. |
Contributor
|
It might make sense to update the hugo and the nodejs version to more recent versions (...that are not EOL). :) |
Member
Author
|
@fredg02 Yeah good point. For some reason I thought changing the defaults would be a breaking change, but never mind. I was overthinking it. |
Contributor
|
Yeah, this is unfortunately a frequent problem with Alpine. Any non-latest version of a package gets removed when updated for a version of Alpine. It's one of the reasons we have pinned versions of the OS and don't always use latest. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, we would like to add Playwright to the
hugo-nodeimage for automated testing with real browsers.I also added Node's bin directory to the path so we don't need to write a bunch of symlinks.