Repository navigation
Conversation
Set session.upload_progress.enabled = Off in the php.ini of the 8.1 to 8.5 images. PHP's informational advisory for CVE-2026-115560 recommends keeping it off until the next regular release, and it was already the mitigation for CVE-2026-109618 and CVE-2026-109619. A site's php.ini comes from the image when the site is created, and on macOS the image's php.ini is used as is, so new sites get the safe default even without a custom.ini line. custom.ini is read after php.ini, so a site that needs upload progress can still set it to On there.
There was a problem hiding this comment.
🟢 Approval recommended
The five small configuration changes consistently implement the intended security default, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Disables session upload progress by default in EasyEngine’s PHP 8.1–8.5 images, extending the security mitigation to image-level configuration. Existing sites retain their own configuration.
Changes:
- Sets
session.upload_progress.enabled = Offin all five published PHP image configurations. - Adds a comment explaining the security default and the site-level
custom.inioverride.
| File | Description |
|---|---|
| php/8.5/php.ini | Disables upload progress by default for PHP 8.5. |
| php/8.4/php.ini | Disables upload progress by default for PHP 8.4. |
| php/8.3/php.ini | Disables upload progress by default for PHP 8.3. |
| php/8.2/php.ini | Disables upload progress by default for PHP 8.2. |
| php/8.1/php.ini | Disables upload progress by default for PHP 8.1. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Set
session.upload_progress.enabled = Offin thephp.iniof the PHP 8.1, 8.2, 8.3, 8.4 and 8.5 images, right below the commented-out default in the[Session]upload-progress block.Why
PHP's informational advisory of 2026-10-23 for CVE-2026-115560 (https://www.php.net/archive/2026.php#2026-10-23-1) asks to keep session upload progress off until the next regular bugfix release. It was already the recommended mitigation for CVE-2026-109618 and CVE-2026-109619, and it is the main protection on 8.1, which gets no fixed PHP release.
v4.13.3 turned it off through each site's
custom.ini. The images still had PHP's default, On, so anything that brings back acustom.iniwithout the line, or never had it, ran with it On:/usr/local/etc) is copied from the image when the site is created, so new sites now get Off fromphp.inias well as fromcustom.ini;php.iniis used as is (the site'scustom.iniis mounted outside the scannedconf.dthere), so this is the first change that turns it off on macOS.Existing sites keep their own copy of
php.ini, so this doesn't change them. Restoring a backup taken before v4.13.3 also replacesphp.iniandcustom.iniwith the backup's copies; EasyEngine/site-command#520 handles that case.custom.iniis read afterphp.ini, so a site that needs upload progress can still setsession.upload_progress.enabled = Onthere.Scope
Only the images this workflow builds and publishes (8.1–8.5).
php/5.6tophp/8.0andphp/stablearen't built by CI, so changing theirphp.iniwouldn't ship anywhere and couldn't be tested here; a future rebuild of 7.4/8.0 should carry the same line.Testing
Each image was built from this branch on a fresh runner and compared with the published
easyengine/php<version>:v4.13.3:php -ishowssession.upload_progress.enabled => Off => Off(On on v4.13.3)./usr/local/etc, populated from the image, plus a sitecustom.ini), the populatedphp.inihas the line, PHP-FPM reports it Off, and acustom.iniwithsession.upload_progress.enabled = Onturns it back On, withupload_max_filesizefromcustom.inistill applied.ini_get_all()from the CLI and from PHP-FPM (with and without acustom.ini) differs from v4.13.3 only insession.upload_progress.enabled; with thecustom.iniOn, the FPM output is identical to v4.13.3.Merges cleanly with #367, #372 and #373.