Skip to content

adds icechunk catalog#670

Merged
lazarusA merged 7 commits into
mainfrom
la/catalogs
Jun 21, 2026
Merged

adds icechunk catalog#670
lazarusA merged 7 commits into
mainfrom
la/catalogs

Conversation

@lazarusA

Copy link
Copy Markdown
Member

Several improvements to the datasets modal. Also, the icechunk catalog is now available. More options for testing.

Screenshot 2026-06-21 at 17 30 44 Screenshot 2026-06-21 at 17 30 36 Screenshot 2026-06-21 at 17 30 25 Screenshot 2026-06-21 at 17 29 59

@lazarusA lazarusA changed the title adds icechunk catalogs adds icechunk catalog Jun 21, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the dataset selection modal by replacing the curated datasets tab with a reusable StoreCatalog component. This new component is integrated into both the Remote Zarr and Icechunk tabs, allowing users to search and select pre-configured stores from catalogs, which then pre-fill the respective URL inputs. Feedback on these changes highlights a potential bug in the infinite scroll useEffect dependency array within StoreCatalog, suggests making the onOpenDescription prop optional, recommends using Tailwind CSS gradient utilities instead of raw CSS variables to prevent rendering issues, and flags an unused useEffect import in RemoteZarr.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/components/ui/MainPanel/StoreCatalog.tsx Outdated
Comment thread src/components/ui/MainPanel/StoreCatalog.tsx Outdated
Comment thread src/components/ui/MainPanel/StoreCatalog.tsx
Comment thread src/components/ui/MainPanel/StoreCatalog.tsx
Comment thread src/components/ui/MainPanel/RemoteZarr.tsx Outdated
@lazarusA lazarusA merged commit ac49bae into main Jun 21, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant