Fix: Add password validation to registration endpoint#4387
Open
yangbobo2021 wants to merge 1 commit intoEarlo:mainfrom
Open
Fix: Add password validation to registration endpoint#4387yangbobo2021 wants to merge 1 commit intoEarlo:mainfrom
yangbobo2021 wants to merge 1 commit intoEarlo:mainfrom
Conversation
Fix security vulnerability where empty passwords were accepted during user registration. Changes: - Add password validation before hashing (reject empty/whitespace passwords) - Add minimum password length requirement (8 characters) - Add comprehensive test coverage for password validation Security: Prevents unauthorized account creation with empty passwords. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the earlo's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix security vulnerability where empty passwords were accepted during user registration.
Problem
The registration endpoint did not validate passwords before processing them, allowing attackers to create user accounts with empty passwords.
Changes
Security Impact
Prevents unauthorized account creation with empty passwords, addressing a HIGH severity vulnerability (Risk Score: 9/10).
Test Results
All tests pass (10/10)
How to Test
Run the test suite:
npm test