Repository navigation
Fix truncated replies on short add() - #499
Merged
Merged
Conversation
We no longer use RESPONSE_WAIT_ACK in built-in responses; remove the unnecessary checks.
Correct state tracking so the connection isn't closed until its queued to the TCP socket.
mathieucarbou
approved these changes
Oct 24, 2026
mathieucarbou
left a comment
mathieucarbou
left a comment
Member
There was a problem hiding this comment.
I understand the fix and it is better indeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix AsyncAbstractResponse handling when the last block of data read is unable to be completely queued to the TCP socket. Instead of moving directly to
RESPONSE_STATE_END, hold the response inRESPONSE_WAIT_ACKuntil the last block has been accepted.Ref: #497