Expand Dataset.from_files so it works properly with derived variables#2777
Expand Dataset.from_files so it works properly with derived variables#2777
Dataset.from_files so it works properly with derived variables#2777Conversation
…es_with_derived_vars
…iables is not possible
Co-authored-by: Bouwe Andela <b.andela@esciencecenter.nl>
|
My apologies for being slow with looking at this. I agree that it would be a great feature, but I don't know if this is the right way to implement it. I would like to investigate if we can find a way to do it without making the Dataset class more complicated. I'll try to find time to do that soon. |
|
Thanks for your answer. I am sorry to hear that this is not the "right" way of implementing it. It would have been nice to receive this kind of feedback after I opened the corresponding issue in July 2025, after opening an associated PR that also clearly outlined this plan in July 2025, after opening this PR in July 2025, or at least after my answer to your comments last month. This would have saved me at least 3 days of work (adapting this to the new data sources configuration alone took me a full day 2 weeks ago). |
|
Just ran into this problem again...would be nice to have a proper solution to that at some point. |
|
Hi Manuel, I had a look this morning and came up with an alternative that requires fewer changes to the existing code: #3051. Do you think that could work? |
|
and I did another one in #3053 |
Description
This PR expands
Dataset.from_filesso it works properly with derived variables. In addition, a new attributeDataset.input_datasetsis available which returns the datasets necessary for derivation (or simply the dataset itself is no derivation is required). This can also be used within thederivepreprocessor function.This PR is the second step to make
Dataset.loadwork with derived variables.Example
Related to #2769.
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: