refactor(biogeophys): Rename frac_sno and frac_sno_eff to clarify albedo vs flux roles - #4185
Open
johnpaulalex wants to merge 2 commits into
Open
refactor(biogeophys): Rename frac_sno and frac_sno_eff to clarify albedo vs flux roles#4185johnpaulalex wants to merge 2 commits into
johnpaulalex wants to merge 2 commits into
Conversation
added 2 commits
August 26, 2026 15:54
Contributor
|
Thanks for tackeling this, @johnpaulalex. Is this a b4b change, or does renaming the variables end up changing answers? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR addresses ESCOMP/CTSM Issue #822 to resolve ambiguity around snow fraction variables by renaming them according to their primary intended physical roles:
frac_sno->frac_sno_albedo(snow cover fraction for radiation and surface albedo)frac_sno_eff->frac_sno_fluxes(effective snow cover fraction for fluxes and thermodynamics)The changes are structured across two stacked commits:
444d2e18b): Corrects 8 subroutineassociateblocks wherewaterdiagnosticbulk_inst%frac_sno_eff_colwas incorrectly aliased to the local namefrac_sno.450531d65): Performs global renaming across 32 source and test modules while adding colon-delimited restart fallback variable names (frac_sno_albedo:frac_snoandfrac_sno_fluxes:frac_sno_eff) inWaterDiagnosticBulkType.F90to preserve restart backward compatibility.History output field names (
FSNO,FSNO_ICE,FSNO_EFF) remain unchanged.Specific notes
Contributors other than yourself, if any:
CTSM issues resolved or otherwise addressed, if any:
Description of generative AI usage:
Any user interface changes (namelist or namelist defaults changes)?
Testing planned or performed, if any:
git log -n 2).frac_sno/frac_sno_effvariable references.test_DustEmisLeung2023.pf,test_DustEmisZender2003.pf, andunittestDustEmisInputs.F90.Requirements before merge: