cam6_4_200?: Remove PS noise in SE-CSLAM, WACCM stability and other stuff - #1664
Open
PeterHjortLauritzen wants to merge 30 commits into
Open
cam6_4_200?: Remove PS noise in SE-CSLAM, WACCM stability and other stuff#1664PeterHjortLauritzen wants to merge 30 commits into
PeterHjortLauritzen wants to merge 30 commits into
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…om pg3 to GLL, hypervis bug fix
…ion sponge in physics
# Conflicts: # src/dynamics/se/dycore/fvm_consistent_se_cslam.F90
ne30pg3 model_top=mt keeps -1 (operational) only for non-WACCM; the waccm_phys=1 variant gets the validated filter default 1.0.
…subcycle fix New namelist switch se_gll_advect_q (default off, b4b with production): under CSLAM, restore cam6_3_151-style GLL advection of thermodynamic tracers alongside CSLAM transport (2-timelevel Qdp, FQ forcing coupling, advection buffers) instead of the cslam2gll overwrite. Also: - Fix unstable auto-selection of hypervis_subcycle (drop 1.2 factor). NOT b4b vs baselines run with the old auto value; set se_hypervis_subcycle explicitly to reproduce those. Note that noise in abs_dps_dt was fixed with this (with gll double-advection setting)
Conflicts resolved in favor of this branch, which supersedes the cam6_4_199 (PR ESCOMP#1656) changes it already contains: - global_norms_mod.F90: keep the automatic hypervis_subcycle formula without the 1.2 fudge factor (removed on this branch, ESCOMP#1595) - namelist_defaults_cam.xml: keep the removal of the WACCM se_hypervis_subcycle overrides (automatic -1 default) - prim_driver_mod.F90: keep the gll_advect_q path and the unconditional cslam2gll (the .not.last_step guard is incompatible with hypervis_Qdp) - control_mod/fvm_mod/dyn_comp: keep the CSLAM Q filter and gll_advect_q declarations/plumbing - doc/ChangeLog: replace this branch's draft entry for PR ESCOMP#1656 with the official cam6_4_199 entry, below the pending entry Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
cacraigucar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1595 Remove subtle noise in PS in SE-CSLAM
closes #1648 Wrong dycore settings when running WACCM physics with LT
closes #1523 optimize SE dycore for WACCM ne30pg3 and ne16pg3
closes #1487 2 degree (ne16pg3) out-of-the-box LT and MT functionality
closes #574 Setting time-steps based on model top location
Also other changes like default topo file for ne120pg3 etc. See ChangeLog for details