Short-lived halogen chemistry #1470
Conversation
new file: cime_config/testdefs/testmods_dirs/cam/ts_slh_mam4_outfrq9s/shell_commands new file: cime_config/testdefs/testmods_dirs/cam/ts_slh_mam4_outfrq9s/user_nl_cam new file: cime_config/testdefs/testmods_dirs/cam/ts_slh_mam4_outfrq9s/user_nl_clm new file: cime_config/testdefs/testmods_dirs/cam/wa_slh_mam4_outfrq9s/shell_commands new file: cime_config/testdefs/testmods_dirs/cam/wa_slh_mam4_outfrq9s/user_nl_cam new file: cime_config/testdefs/testmods_dirs/cam/wa_slh_mam4_outfrq9s/user_nl_clm
|
From @RafaPedroFernandez (CC'd @CAlbertoCuevas): Please note that I have just made a push for 2 F90 routines in my following GIT: Which is also updated local in derecho: Routines are mo_gas_phase_chmdr.F90 Including snow in the variable makes the iodine deposition too efficient, and then we created a new array (ONLYICE) just to compute iodine wet-depositions without affecting other model developments. |
modified: src/chemistry/mozart/chemistry.F90 modified: src/chemistry/mozart/mo_gas_phase_chemdr.F90
modified: src/chemistry/mozart/mo_usrrxt.F90
cacraigucar
left a comment
cacraigucar
left a comment
There was a problem hiding this comment.
Partial review - @jimmielin will be reviewing the chemistry section of this PR. My review was on the setup side.
I noticed that there are testing use_cases setup, but I do not see any regression tests being added. Is this an oversight?
| <xs_short_file>atm/waccm/phot/xs_short_c221005mm_slh_c250930.nc</xs_short_file> | ||
| <xs_long_file >atm/waccm/phot/temp_prs_GT200nm_c221005mm_slh_c250930.nc</xs_long_file> |
There was a problem hiding this comment.
These two file still need to be "rimport"ed
| <entry id="SSAhno3_ScalingFactor" type="real" category="cam_chem" | ||
| group="slh_nl" valid_values="" > | ||
| Scaling-factor for SLH Halocarbon surface emissions | ||
| Default: set by build-namelist | ||
| </entry> | ||
|
|
||
| <entry id="SSAn2o5_ScalingFactor" type="real" category="cam_chem" | ||
| group="slh_nl" valid_values="" > | ||
| Scaling-factor for SLH Halocarbon surface emissions | ||
| Default: set by build-namelist | ||
| </entry> | ||
|
|
||
| <entry id="LIQfraprx_ScalingFactor_I" type="real" category="cam_chem" | ||
| group="slh_nl" valid_values="" > | ||
| Scaling-factor for SLH Halocarbon surface emissions | ||
| Default: set by build-namelist | ||
| </entry> | ||
|
|
||
| <entry id="ICEfraprx_ScalingFactor_I" type="real" category="cam_chem" | ||
| group="slh_nl" valid_values="" > | ||
| Scaling-factor for SLH Halocarbon surface emissions | ||
| Default: set by build-namelist | ||
| </entry> | ||
|
|
||
| <entry id="ICEfraprx_ScalingFactor_Br" type="real" category="cam_chem" | ||
| group="slh_nl" valid_values="" > | ||
| Scaling-factor for SLH Halocarbon surface emissions | ||
| Default: set by build-namelist | ||
| </entry> |
There was a problem hiding this comment.
Comments probably need updating (since they are all the same)
| <value compset="HIST_CAM60%CFIRE">1995-01-01</value> | ||
| <value compset="RCP[2468]_CAM\d+">2005-01-01</value> | ||
| <value compset="_CAM.*%NUDG" >2010-01-01</value> | ||
| <value compset="_CAM.*%NUDG" >2000-01-01</value> |
There was a problem hiding this comment.
Why is this PR changing the date for nudging runs?
2 participants
Closes #1469